Skip to content

Commit 671be9e

Browse files
committed
feat: add test case
1 parent 4940418 commit 671be9e

11 files changed

Lines changed: 66 additions & 26 deletions

File tree

trpc-core/src/main/java/com/tencent/trpc/core/transport/AbstractClientTransport.java

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -229,11 +229,8 @@ protected CompletionStage<Channel> createChannel() throws TransportException {
229229
if (t != null) {
230230
logger.error("Client transport({}) create connection exception", this.toString(), t);
231231
} else {
232-
if (logger.isDebugEnabled()) {
233-
logger.debug("Client transport(remote addr={}, network={}) create connection success",
234-
rAddr, config.getNetwork());
235-
}
236-
232+
logger.debug("Client transport(remote addr={}, network={}) create connection success",
233+
rAddr, config.getNetwork());
237234
}
238235
// to prevent connection leakage, do one more check: when the connection is successfully established, if
239236
// it is found to be closed, close the established connection directly

trpc-core/src/test/java/com/tencent/trpc/core/cluster/RpcClusterClientManagerTest.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,10 @@ public void test() throws IllegalArgumentException, IllegalAccessException, NoSu
4343
Thread.sleep(10);
4444
RpcClusterClientManager.scanUnusedClient();
4545
assertEquals(0, clusterMap.get(backendConfig).size());
46+
BackendConfig backend = new BackendConfig();
47+
backend.setNamingUrl("ip://127.0.0.1:8081");
48+
RpcClusterClientManager.getOrCreateClient(backend, config);
49+
RpcClusterClientManager.shutdownBackendConfig(backend);
4650
}
4751

4852
private static class ProtocolConfigTest extends ProtocolConfig {
Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
package com.tencent.trpc.core.common;
2+
3+
import org.junit.Test;
4+
5+
public class LifecycleBaseTest {
6+
7+
@Test
8+
public void testDebug() {
9+
TestLifecycle testLifecycle = new TestLifecycle();
10+
testLifecycle.init();
11+
}
12+
13+
public class TestLifecycle extends LifecycleBase {
14+
15+
}
16+
}

trpc-core/src/test/java/com/tencent/trpc/core/trace/TraceServerFilterTest.java

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -235,6 +235,26 @@ public void testTRpcExceptionSpan() {
235235
filter.filter(invoker, request);
236236
}
237237

238+
@Test
239+
public void testDebugLog() {
240+
RpcServerContext context = new RpcServerContext();
241+
Request request = new DefRequest();
242+
request.setContext(context);
243+
RpcInvocation invocation = new RpcInvocation();
244+
invocation.setRpcServiceName("rpcServiceName");
245+
invocation.setRpcMethodName("rpcMethodName");
246+
request.getMeta().setRemoteAddress(InetSocketAddress.createUnresolved("10.0.0.1", 8888));
247+
request.getMeta().setLocalAddress(InetSocketAddress.createUnresolved("10.0.0.1", 9999));
248+
request.setInvocation(invocation);
249+
CompletableFuture<Response> future = new CompletableFuture<Response>();
250+
Response rsp = new DefResponse();
251+
rsp.setException(TRpcException.newBizException(10, ""));
252+
future.complete(rsp);
253+
Invoker<?> invoker = (Invoker<?>) PowerMockito.mock(Invoker.class);
254+
PowerMockito.when(invoker.invoke(request)).thenReturn(future);
255+
filter.filter(invoker, request);
256+
}
257+
238258
private static class TestTraceFactory implements TracerFactory {
239259

240260
@Override
Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
package com.tencent.trpc.core.transport.handler;
2+
3+
import com.tencent.trpc.core.common.config.ProtocolConfig;
4+
import com.tencent.trpc.core.transport.common.TestChannel;
5+
import org.junit.Test;
6+
7+
public class ChannelHandlerAdapterTest {
8+
9+
@Test
10+
public void testDebug() {
11+
ChannelHandlerAdapter channelHandlerAdapter = new ChannelHandlerAdapter();
12+
ProtocolConfig protocolConfig = ProtocolConfig.newInstance();
13+
protocolConfig.setIp("127.0.0.1");
14+
protocolConfig.setPort(8888);
15+
channelHandlerAdapter.disconnected(new TestChannel(protocolConfig));
16+
}
17+
}

trpc-proto/trpc-proto-standard/src/main/java/com/tencent/trpc/proto/standard/stream/TRpcStreamResponder.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,9 +59,7 @@ public TRpcStreamResponder(ProtocolConfig protocolConfig, RpcConnection connecti
5959
DefMethodInfoRegister methodInfoRegister) {
6060
super(protocolConfig, connection);
6161
this.methodInfoRegister = Objects.requireNonNull(methodInfoRegister, "methodInfoRegister is null");
62-
if (logger.isDebugEnabled()) {
63-
logger.debug("created new rpcResponder for {}", protocolConfig);
64-
}
62+
logger.debug("created new rpcResponder for {}", protocolConfig);
6563
}
6664

6765
@Override

trpc-proto/trpc-proto-standard/src/main/java/com/tencent/trpc/proto/standard/stream/client/StreamConsumerInvoker.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
/*
22
* Tencent is pleased to support the open source community by making tRPC available.
33
*
4-
* Copyright (C) 2023 Tencent.
4+
* Copyright (C) 2023 Tencent.
55
* All rights reserved.
66
*
77
* If you have downloaded a copy of the tRPC source code from Tencent,
@@ -69,7 +69,7 @@ public class StreamConsumerInvoker<T> implements ConsumerInvoker<T> {
6969
private final ClientTransport clientTransport;
7070

7171
public StreamConsumerInvoker(ConsumerConfig<T> consumerConfig, ProtocolConfig protocolConfig,
72-
ClientTransport clientTransport) {
72+
ClientTransport clientTransport) {
7373
this.consumerConfig = Objects.requireNonNull(consumerConfig, "consumerConfig is null");
7474
this.backendConfig = Objects
7575
.requireNonNull(consumerConfig.getBackendConfig(), "backendConfig is null");
@@ -144,9 +144,7 @@ private Object doInvoke(Request request, TRpcStreamRequester requester, RpcConne
144144
AtomicInteger unFinished = new AtomicInteger(STREAM_CLOSE_COUNT_BOTH_DIRECTION);
145145
Consumer<SignalType> onFinally = s -> {
146146
if (unFinished.decrementAndGet() == 0) {
147-
if (logger.isDebugEnabled()) {
148-
logger.debug("close stream invoker connection: {}", connection);
149-
}
147+
logger.debug("close stream invoker connection: {}", connection);
150148
connection.dispose();
151149
}
152150
};

trpc-registry/trpc-registry-api/src/main/java/com/tencent/trpc/registry/center/AbstractFailedRetryRegistryCenter.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -387,9 +387,7 @@ protected void recoverRegistered() {
387387
return;
388388
}
389389
recoverRegistered.forEach(registerInfo -> {
390-
if (logger.isDebugEnabled()) {
391-
logger.debug("[Recover] Register registerInfo: {}", registerInfo);
392-
}
390+
logger.debug("[Recover] Register registerInfo: {}", registerInfo);
393391
addFailedRegisteredTask(registerInfo);
394392
});
395393
}

trpc-registry/trpc-registry-api/src/main/java/com/tencent/trpc/registry/center/AbstractRegistryCenter.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -110,9 +110,7 @@ public void setPluginConfig(PluginConfig pluginConfig) throws TRpcExtensionExcep
110110
@Override
111111
public void register(RegisterInfo registerInfo) {
112112
Objects.requireNonNull(registerInfo, "registerInfo can not be null");
113-
if (logger.isDebugEnabled()) {
114-
logger.debug("[register] registerInfo: {}", registerInfo);
115-
}
113+
logger.debug("[register] registerInfo: {}", registerInfo);
116114
registeredRegisterInfos.add(registerInfo);
117115
}
118116

trpc-registry/trpc-registry-zookeeper/src/main/java/com/tencent/trpc/registry/transporter/curator/CuratorZookeeperClient.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -409,10 +409,7 @@ public void unwatch() {
409409
*/
410410
@Override
411411
public void process(WatchedEvent event) throws Exception {
412-
if (logger.isDebugEnabled()) {
413-
logger.debug("curator watcher process. event: {}", event);
414-
}
415-
412+
logger.debug("curator watcher process. event: {}", event);
416413
if (childListener == null) {
417414
return;
418415
}

0 commit comments

Comments
 (0)