Skip to content

feat: add ServiceConfig field to ProtocolConfig#91

Closed
wangxiao1208 wants to merge 2 commits into
trpc-group:masterfrom
wangxiao1208:master
Closed

feat: add ServiceConfig field to ProtocolConfig#91
wangxiao1208 wants to merge 2 commits into
trpc-group:masterfrom
wangxiao1208:master

Conversation

@wangxiao1208
Copy link
Copy Markdown
Contributor

Add ServiceConfig field to ProtocolConfig to provide more service infomation for the next RpcServer's creation.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 8, 2025


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


1 out of 2 committers have signed the CLA.
✅ (wangxiao1208)[https://github.com/wangxiao1208]
@shorewang
shorewang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@wangxiao1208
Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 8, 2025

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 70.16416%. Comparing base (55273a8) to head (e3a1d69).

Files with missing lines Patch % Lines
...encent/trpc/core/common/config/ProtocolConfig.java 80.00000% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                  @@
##                master         #91         +/-   ##
=====================================================
+ Coverage     70.13617%   70.16416%   +0.02798%     
- Complexity        4242        4246          +4     
=====================================================
  Files              437         437                 
  Lines            17111       17117          +6     
  Branches          1730        1731          +1     
=====================================================
+ Hits             12001       12010          +9     
+ Misses            3986        3983          -3     
  Partials          1124        1124                 
Files with missing lines Coverage Δ
...tencent/trpc/core/common/config/ServiceConfig.java 81.70732% <100.00000%> (+0.07466%) ⬆️
...encent/trpc/core/common/config/ProtocolConfig.java 86.74699% <80.00000%> (-0.43251%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant