Skip to content

feat: add ServiceConfig field to ProtocolConfig #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wangxiao1208 wants to merge 2 commits into from
Closed

feat: add ServiceConfig field to ProtocolConfig #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e901f26
feat: add ServiceConfig field to ProtocolConfig
wangxiao1208 Aug 8, 2025
e3a1d69
feat: add ServiceConfig field to ProtocolConfig
Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions trpc-core/src/main/java/com/tencent/trpc/core/common/config/ProtocolConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ public class ProtocolConfig extends BaseProtocolConfig implements Cloneable {
protected volatile boolean setDefault = false;
protected volatile boolean inited = false;

protected ServiceConfig serviceConfig;

public static ProtocolConfig newInstance() {
return new ProtocolConfig();
}
Expand Down Expand Up @@ -244,4 +246,14 @@ public boolean isInited() {
return inited;
}

public ServiceConfig getServiceConfig() {
return serviceConfig;
}

public void setServiceConfig(ServiceConfig serviceConfig) {
checkFiledModifyPrivilege();
Preconditions.checkArgument(serviceConfig != null, "serviceConfig cannot be null");
this.serviceConfig = serviceConfig;
}

}
1 change: 1 addition & 0 deletions trpc-core/src/main/java/com/tencent/trpc/core/common/config/ServiceConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,6 +402,7 @@ protected ProtocolConfig buildProtocolConfig() {
tempProtocolConfig.setReusePort(this.getReusePort());
tempProtocolConfig.setSign(this.getSign());
tempProtocolConfig.setDefault();
tempProtocolConfig.setServiceConfig(this);
return tempProtocolConfig;
}

Expand Down
4 changes: 4 additions & 0 deletions trpc-core/src/test/java/com/tencent/trpc/core/common/config/ProtocolConfigTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertSame;
import static org.junit.Assert.assertTrue;

import com.google.common.collect.ImmutableMap;
Expand Down Expand Up @@ -90,6 +91,8 @@ public void testConfig() {
config.setExplicitFlushAfterFlushes(1024);
config.setCompressMinBytes(10);
config.setDefault();
ServiceConfig serviceConfig = new ServiceConfig();
config.setServiceConfig(serviceConfig);
assertEquals("127.1.1.1", config.getIp());
assertEquals("", config.getName());
assertEquals(8080, config.getPort());
Expand Down Expand Up @@ -124,5 +127,6 @@ public void testConfig() {
assertFalse(config.useEpoll());
assertEquals(10, config.getCompressMinBytes());
assertTrue(config.isSetDefault());
assertSame(serviceConfig, config.getServiceConfig());
}
}
Loading