Fix awaitCompletion/awaitAfterCancellation not marking Future as used

Cancellation tokens passed to Scope::awaitCompletion() and
Scope::awaitAfterCancellation() were never marked RESULT_USED/EXC_CAUGHT,
causing spurious "Future was never used" warnings. Early return paths
(scope already finished/closed/cancelled) bypassed the marking entirely.

Move SET_RESULT_USED + SET_EXC_CAUGHT to immediately after parameter
parsing, before any early returns.

Author: EdmondDantes

CHANGELOG.md

@@ -5,6 +5,12 @@ All notable changes to the Async extension for PHP will be documented in this fi
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.6.6] -
+
+### Fixed
+- **`Scope::awaitCompletion()` not marking cancellation Future as used**: The cancellation token passed to `awaitCompletion()` was never marked with `RESULT_USED` / `EXC_CAUGHT`, causing a spurious "Future was never used" warning when the Future was destroyed. Additionally, early return paths (scope already finished, closed, or cancelled) skipped the marking entirely. Fixed by setting flags immediately after parameter parsing, before any early returns.
+- **`Scope::awaitAfterCancellation()` not marking cancellation Future as used**: Same issue as `awaitCompletion()` — the optional cancellation Future was only marked when the method reached `resume_when`, but early returns bypassed it. Fixed identically.
+
 ## [0.6.5] -
 
 ### Changed

scope.c

@@ -273,6 +273,11 @@ METHOD(awaitCompletion)
 	Z_PARAM_OBJ_OF_CLASS(cancellation_obj, async_ce_awaitable)
 	ZEND_PARSE_PARAMETERS_END();
 
+	// Mark cancellation token as used immediately, before any early returns
+	zend_async_event_t *cancellation_event = ZEND_ASYNC_OBJECT_TO_EVENT(cancellation_obj);
+	ZEND_ASYNC_EVENT_SET_RESULT_USED(cancellation_event);
+	ZEND_ASYNC_EVENT_SET_EXC_CAUGHT(cancellation_event);
+
 	zend_coroutine_t *current_coroutine = ZEND_ASYNC_CURRENT_COROUTINE;
 	if (UNEXPECTED(current_coroutine == NULL)) {
 		return;
@@ -320,7 +325,7 @@ METHOD(awaitCompletion)
 	}
 
 	zend_async_resume_when(current_coroutine,
-						   ZEND_ASYNC_OBJECT_TO_EVENT(cancellation_obj),
+						   cancellation_event,
 						   false,
 						   zend_async_waker_callback_cancel,
 						   NULL);
@@ -345,6 +350,13 @@ METHOD(awaitAfterCancellation)
 	Z_PARAM_OBJ_OR_NULL(cancellation_obj)
 	ZEND_PARSE_PARAMETERS_END();
 
+	// Mark cancellation token as used immediately, before any early returns
+	if (cancellation_obj != NULL) {
+		zend_async_event_t *cancellation_event = ZEND_ASYNC_OBJECT_TO_EVENT(cancellation_obj);
+		ZEND_ASYNC_EVENT_SET_RESULT_USED(cancellation_event);
+		ZEND_ASYNC_EVENT_SET_EXC_CAUGHT(cancellation_event);
+	}
+
 	zend_coroutine_t *current_coroutine = ZEND_ASYNC_CURRENT_COROUTINE;
 	if (UNEXPECTED(current_coroutine == NULL)) {
 		return;

tests/scope/041-scope_awaitCompletion_marks_future_used.phpt

@@ -0,0 +1,39 @@
+--TEST--
+Scope: awaitCompletion() marks cancellation Future as used
+--FILE--
+<?php
+
+use Async\Scope;
+use Async\Future;
+use Async\FutureState;
+use function Async\spawn;
+use function Async\await;
+use function Async\delay;
+
+echo "start\n";
+
+$scope = Scope::inherit();
+$scope->spawn(function() {
+    delay(10);
+});
+
+$state = new FutureState();
+$future = new Future($state);
+
+$external = spawn(function() use ($scope, $future) {
+    $scope->awaitCompletion($future);
+    echo "completed\n";
+});
+
+await($external);
+
+// Destroy the future — must NOT trigger "Future was never used" warning
+unset($future, $state);
+
+echo "end\n";
+
+?>
+--EXPECT--
+start
+completed
+end

tests/scope/042-scope_awaitAfterCancellation_marks_future_used.phpt

@@ -0,0 +1,49 @@
+--TEST--
+Scope: awaitAfterCancellation() marks cancellation Future as used
+--FILE--
+<?php
+
+use Async\Scope;
+use Async\Future;
+use Async\FutureState;
+use function Async\spawn;
+use function Async\await;
+use function Async\delay;
+use function Async\suspend;
+
+echo "start\n";
+
+$scope = Scope::inherit();
+$scope->spawn(function() {
+    try {
+        delay(50);
+    } catch (\Async\OperationCanceledException $e) {
+        // expected
+    }
+});
+
+// Let coroutine start
+suspend();
+
+$scope->cancel();
+
+$state = new FutureState();
+$future = new Future($state);
+
+$external = spawn(function() use ($scope, $future) {
+    $scope->awaitAfterCancellation(null, $future);
+    echo "completed\n";
+});
+
+await($external);
+
+// Destroy the future — must NOT trigger "Future was never used" warning
+unset($future, $state);
+
+echo "end\n";
+
+?>
+--EXPECT--
+start
+completed
+end