Skip to content

fix(renovate): unblock container test against upstream HEALTHCHECK#1842

Merged
Crow-Control merged 1 commit intomainfrom
copilot/fix-open-pull-request-issues
Apr 18, 2026
Merged

fix(renovate): unblock container test against upstream HEALTHCHECK#1842
Crow-Control merged 1 commit intomainfrom
copilot/fix-open-pull-request-issues

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 18, 2026

PR #1510 (renovate 43.29.2 → 43.128.0) fails Build renovate / Test with wait[1/1] health wait docker healthcheck: context deadline exceeded. The new renovate/renovate:43.128.0-full image ships a HEALTHCHECK that never reports healthy when the test framework overrides the entrypoint with sleep 999 — renovate is a CLI, not a service, so there's nothing to probe.

Changes

  • apps/renovate/container-test.yaml: switch from filePaths (which falls back to waiting on the container's docker healthcheck) to a runners:-based test that invokes the binary directly, matching the pattern used by apps/yq and apps/go-yq.
    • mainRunner.enabled: false skips the default health-wait gate.
    • runners[0].entrypoint: renovate --version exercises the binary.
mainRunner:
  enabled: false

runners:
- entrypoint: renovate --version

Scope notes

Of the 11 currently open PRs, this is the only one with an in-scope, clearly-fixable CI failure landable from main. Once merged, Renovate will rebase #1510 and the test job should go green. The other open PRs are either renovate patch bumps with no failing checks, BREAKING major bumps requiring human review (#1679, #1644, #1643, #1641), or another agent's in-flight draft (#1563).

@Crow-Control Crow-Control marked this pull request as ready for review April 18, 2026 07:00
@Crow-Control Crow-Control requested a review from alfi0812 as a code owner April 18, 2026 07:00
Copilot AI review requested due to automatic review settings April 18, 2026 07:00
@Crow-Control Crow-Control merged commit 49b126f into main Apr 18, 2026
2 checks passed
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the Renovate app’s container test configuration to avoid CI timeouts caused by an upstream Docker HEALTHCHECK that never becomes healthy when the test framework overrides the entrypoint (e.g., sleep 999). It switches the test to directly execute the Renovate CLI instead of relying on health-wait behavior.

Changes:

  • Disable the default/main runner to avoid healthcheck-based gating.
  • Add a runner that validates the image by executing renovate --version.

@alfi0812 alfi0812 deleted the copilot/fix-open-pull-request-issues branch April 18, 2026 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants