fix(renovate): unblock container test against upstream HEALTHCHECK#1842
Merged
Crow-Control merged 1 commit intomainfrom Apr 18, 2026
Merged
fix(renovate): unblock container test against upstream HEALTHCHECK#1842Crow-Control merged 1 commit intomainfrom
Crow-Control merged 1 commit intomainfrom
Conversation
Agent-Logs-Url: https://github.com/trueforge-org/containerforge/sessions/ba7954de-c7c5-4525-bd8e-e03b8c31d37c Co-authored-by: Crow-Control <7613738+Crow-Control@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
Crow-Control
April 18, 2026 06:51
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the Renovate app’s container test configuration to avoid CI timeouts caused by an upstream Docker HEALTHCHECK that never becomes healthy when the test framework overrides the entrypoint (e.g., sleep 999). It switches the test to directly execute the Renovate CLI instead of relying on health-wait behavior.
Changes:
- Disable the default/main runner to avoid healthcheck-based gating.
- Add a runner that validates the image by executing
renovate --version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #1510 (
renovate 43.29.2 → 43.128.0) failsBuild renovate / Testwithwait[1/1] health wait docker healthcheck: context deadline exceeded. The newrenovate/renovate:43.128.0-fullimage ships aHEALTHCHECKthat never reports healthy when the test framework overrides the entrypoint withsleep 999— renovate is a CLI, not a service, so there's nothing to probe.Changes
apps/renovate/container-test.yaml: switch fromfilePaths(which falls back to waiting on the container's docker healthcheck) to arunners:-based test that invokes the binary directly, matching the pattern used byapps/yqandapps/go-yq.mainRunner.enabled: falseskips the default health-wait gate.runners[0].entrypoint: renovate --versionexercises the binary.Scope notes
Of the 11 currently open PRs, this is the only one with an in-scope, clearly-fixable CI failure landable from
main. Once merged, Renovate will rebase #1510 and the test job should go green. The other open PRs are either renovate patch bumps with no failing checks, BREAKING major bumps requiring human review (#1679, #1644, #1643, #1641), or another agent's in-flight draft (#1563).