Skip to content

fix(ci): release autofix for diskover and kasm on Ubuntu 26.04 base#2319

Merged
Crow-Control merged 2 commits into
mainfrom
copilot/fix-release-failure-diskover-kasm
May 7, 2026
Merged

fix(ci): release autofix for diskover and kasm on Ubuntu 26.04 base#2319
Crow-Control merged 2 commits into
mainfrom
copilot/fix-release-failure-diskover-kasm

Conversation

Copilot AI commented May 7, 2026

Copy link
Copy Markdown
Contributor

Release build run 25485774052 failed for diskover and kasm after the shared python-node / ubuntu base bumped to Ubuntu 26.04 (resolute), which dropped apt-key and PHP 8.3, and after upstream Kasm relocated its release tarball.

apps/diskover

  • php8.3-cli / php8.3-fpm / php8.3-sqlite3 no longer exist on the new base — switched to versionless php-cli / php-fpm / php-sqlite3 (Ubuntu 26.04 ships PHP 8.5 as default).
  • Replaced the hardcoded /etc/php83/... Alpine-style config path with a glob over /etc/php/*/fpm/pool.d/www.conf.
  • start.sh now invokes php -S instead of php8.3 -S.

apps/kasm

  • apt-key was removed in Ubuntu 26.04 → added Docker's GPG key via gpg --dearmor into /usr/share/keyrings/ and reference it with signed-by= in docker.list.
  • kasm_release_<ver>.tar.gz is no longer published as a GitHub release asset on kasmtech/kasm-install-wizard (404) → switched to the canonical https://kasm-static-content.s3.amazonaws.com/kasm_release_<ver>.tar.gz used by upstream's installer.
  • Dropped the now-dead kasm-ci.s3 …-images-combined.tar.gz fetch (Kasm pulls images at runtime in current versions) and the obsolete www/img/thumbnails copy + yq proxy.volumes tweak — neither path exists in the current tarball.

No version bumps, no test weakening; both changes are scoped to their respective apps/<app>/ directories.

Sandbox-imposed deviation

The autofix protocol calls for one PR per app. The Copilot agent token in this sandbox can only push to the pre-existing branch, so both fixes are bundled here as two disjoint Conventional-Commit commits (apps/diskover/** and apps/kasm/Dockerfile) that can be cherry-picked apart if per-app PRs are preferred. The summary comment for the source issue could also not be posted from the sandbox and is left for a maintainer.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

actions-user and others added 2 commits May 7, 2026 12:26
…noble base

Upstream python-node base image is now Ubuntu 26.04 (resolute), which
ships PHP 8.5 by default; the previously hardcoded php8.3-cli /
php8.3-style fpm config paths no longer exist, causing apt to fail to
locate the package and breaking the release build (run 25485774052).

- Switch to versionless php-cli / php-fpm / php-sqlite3 packages so
  the Dockerfile follows the base image's default PHP version.
- Replace the Alpine-style /etc/php83 config-tweak with a glob over
  /etc/php/*/fpm/pool.d/www.conf so it works on any Debian/Ubuntu PHP.
- Update start.sh to invoke the default 'php' binary instead of php8.3.

Co-authored-by: Crow-Control <7613738+Crow-Control@users.noreply.github.com>
…g thumbnails

The kasm release build (run 25485774052) failed at the very first
'apt-key add -' invocation because apt-key was removed from the new
Ubuntu 26.04 (resolute) base image. Two further upstream changes were
also broken:

- The Docker GPG key is now imported via gpg --dearmor into
  /usr/share/keyrings and referenced through 'signed-by=' in the
  docker.list source, matching the modern keyring pattern.
- The kasm_release tarball is no longer published as a GitHub release
  asset on kasmtech/kasm-install-wizard; switch to the official
  https://kasm-static-content.s3.amazonaws.com/kasm_release_<ver>.tar.gz
  URL used by upstream installer / linuxserver.
- Drop the docker-image-preload step (kasm-ci.s3 images-combined
  tarball no longer exists for current versions and is fetched at
  runtime by Kasm itself), and remove the obsolete www/img/thumbnails
  copy + yq tweak (the thumbnails directory no longer exists in the
  kasm_release tarball).

Co-authored-by: Crow-Control <7613738+Crow-Control@users.noreply.github.com>
@Crow-Control Crow-Control force-pushed the copilot/fix-release-failure-diskover-kasm branch from 348e34a to 04c3ac6 Compare May 7, 2026 10:26
Copilot AI changed the title [WIP] Fix CI release failure for diskover and kasm fix(ci): release autofix for diskover and kasm on Ubuntu 26.04 base May 7, 2026
Copilot AI requested a review from Crow-Control May 7, 2026 10:29
@trueforge-bot

trueforge-bot Bot commented May 7, 2026

Copy link
Copy Markdown

📦 App Size Analysis

Note

Comparing ghcr.io/trueforge-org/diskover:rollingghcr.io/trueforge-org/diskover:sandbox

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 369.75 MB 632.33 MB +262.57 MB (+71.01%) 🔼
linux/arm64 361.09 MB 381.95 MB +20.87 MB (+5.78%) 🔼

@trueforge-bot

trueforge-bot Bot commented May 7, 2026

Copy link
Copy Markdown

📦 App Size Analysis

Note

Comparing ghcr.io/trueforge-org/kasm:rollingghcr.io/trueforge-org/kasm:sandbox

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 507.75 MB 786.26 MB +278.52 MB (+54.85%) 🔼
linux/arm64 488.65 MB 525.73 MB +37.08 MB (+7.59%) 🔼

@Crow-Control Crow-Control marked this pull request as ready for review May 7, 2026 11:34
Copilot AI review requested due to automatic review settings May 7, 2026 11:34
@Crow-Control Crow-Control requested a review from alfi0812 as a code owner May 7, 2026 11:34
@Crow-Control Crow-Control merged commit cd2327b into main May 7, 2026
22 of 24 checks passed
@Crow-Control Crow-Control deleted the copilot/fix-release-failure-diskover-kasm branch May 7, 2026 11:34
Copilot stopped work on behalf of Crow-Control due to an error May 7, 2026 11:35
Copilot AI removed the request for review from Copilot May 7, 2026 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(ci): release failure for diskover, kasm (run 25485774052)

4 participants