fix(ci): release autofix for diskover and kasm on Ubuntu 26.04 base#2319
Merged
Conversation
|
|
…noble base Upstream python-node base image is now Ubuntu 26.04 (resolute), which ships PHP 8.5 by default; the previously hardcoded php8.3-cli / php8.3-style fpm config paths no longer exist, causing apt to fail to locate the package and breaking the release build (run 25485774052). - Switch to versionless php-cli / php-fpm / php-sqlite3 packages so the Dockerfile follows the base image's default PHP version. - Replace the Alpine-style /etc/php83 config-tweak with a glob over /etc/php/*/fpm/pool.d/www.conf so it works on any Debian/Ubuntu PHP. - Update start.sh to invoke the default 'php' binary instead of php8.3. Co-authored-by: Crow-Control <7613738+Crow-Control@users.noreply.github.com>
…g thumbnails The kasm release build (run 25485774052) failed at the very first 'apt-key add -' invocation because apt-key was removed from the new Ubuntu 26.04 (resolute) base image. Two further upstream changes were also broken: - The Docker GPG key is now imported via gpg --dearmor into /usr/share/keyrings and referenced through 'signed-by=' in the docker.list source, matching the modern keyring pattern. - The kasm_release tarball is no longer published as a GitHub release asset on kasmtech/kasm-install-wizard; switch to the official https://kasm-static-content.s3.amazonaws.com/kasm_release_<ver>.tar.gz URL used by upstream installer / linuxserver. - Drop the docker-image-preload step (kasm-ci.s3 images-combined tarball no longer exists for current versions and is fetched at runtime by Kasm itself), and remove the obsolete www/img/thumbnails copy + yq tweak (the thumbnails directory no longer exists in the kasm_release tarball). Co-authored-by: Crow-Control <7613738+Crow-Control@users.noreply.github.com>
348e34a to
04c3ac6
Compare
Copilot
AI
changed the title
[WIP] Fix CI release failure for diskover and kasm
fix(ci): release autofix for diskover and kasm on Ubuntu 26.04 base
May 7, 2026
📦 App Size AnalysisNote Comparing 📈 Size Comparison Table
|
📦 App Size AnalysisNote Comparing 📈 Size Comparison Table
|
Copilot stopped work on behalf of
Crow-Control due to an error
May 7, 2026 11:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release build run 25485774052 failed for
diskoverandkasmafter the sharedpython-node/ubuntubase bumped to Ubuntu 26.04 (resolute), which droppedapt-keyand PHP 8.3, and after upstream Kasm relocated its release tarball.apps/diskoverphp8.3-cli/php8.3-fpm/php8.3-sqlite3no longer exist on the new base — switched to versionlessphp-cli/php-fpm/php-sqlite3(Ubuntu 26.04 ships PHP 8.5 as default)./etc/php83/...Alpine-style config path with a glob over/etc/php/*/fpm/pool.d/www.conf.start.shnow invokesphp -Sinstead ofphp8.3 -S.apps/kasmapt-keywas removed in Ubuntu 26.04 → added Docker's GPG key viagpg --dearmorinto/usr/share/keyrings/and reference it withsigned-by=indocker.list.kasm_release_<ver>.tar.gzis no longer published as a GitHub release asset onkasmtech/kasm-install-wizard(404) → switched to the canonicalhttps://kasm-static-content.s3.amazonaws.com/kasm_release_<ver>.tar.gzused by upstream's installer.kasm-ci.s3 …-images-combined.tar.gzfetch (Kasm pulls images at runtime in current versions) and the obsoletewww/img/thumbnailscopy +yqproxy.volumestweak — neither path exists in the current tarball.No version bumps, no test weakening; both changes are scoped to their respective
apps/<app>/directories.Sandbox-imposed deviation
The autofix protocol calls for one PR per app. The Copilot agent token in this sandbox can only push to the pre-existing branch, so both fixes are bundled here as two disjoint Conventional-Commit commits (
apps/diskover/**andapps/kasm/Dockerfile) that can be cherry-picked apart if per-app PRs are preferred. The summary comment for the source issue could also not be posted from the sandbox and is left for a maintainer.