[INS-469] Added Rev detectors to defaults.go and gated it behind feature flag#5005
Open
MuneebUllahKhan222 wants to merge 2 commits into
Open
[INS-469] Added Rev detectors to defaults.go and gated it behind feature flag#5005MuneebUllahKhan222 wants to merge 2 commits into
MuneebUllahKhan222 wants to merge 2 commits into
Conversation
Corpora Test ResultsNo detector regex or keyword changes in this PR. Bench skipped. |
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7a56052. Configure here.
shahzadhaider1
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description:
This PR adds the existing
Revdetector todefaults.goand ensures it is gated behind the appropriate feature flag.Additionally, the PR updates the assertions in the existing integration tests to account for the changes made to the
detector.Resultstruct.Corpora Test:
The detector doesn't appear in the list.

Checklist:
make test-community)?make lintthis requires golangci-lint)?Note
Medium Risk
Turning on a new default detector increases scan surface and live Rev API verification traffic; behavior is mitigated by a feature flag but enabled by default in OSS builds.
Overview
This PR enables the existing Rev API credential detector in the default engine detector list and wires it through the same feature-flag pattern used for Pinecone, Cloudinary, and GitLab OAuth (
RevDetectorEnabled, default on in OSSmain).The Rev scanner now records both user and client key parts in
SecretPartsfor multi-part credentials. Rev integration tests were updated to compare results withgo-cmp, ignoring newerdetector.Resultfields that would otherwise make assertions brittle.go.sumgrew with many new transitive module checksum lines (lockfile-only).Note:
defaults_teststill listsDetectorType_Revunder intentionally excluded types until the test list is updated to match registration—worth confirming that test expectations are aligned with this change.Reviewed by Cursor Bugbot for commit fe71c85. Bugbot is set up for automated code reviews on this repo. Configure here.