[INS-470] Add Tly detector to defaults.go, gate it behind feat flag and update its verification logic#5006
Open
MuneebUllahKhan222 wants to merge 2 commits into
Open
[INS-470] Add Tly detector to defaults.go, gate it behind feat flag and update its verification logic#5006MuneebUllahKhan222 wants to merge 2 commits into
MuneebUllahKhan222 wants to merge 2 commits into
Conversation
Corpora Test ResultsNo detector regex or keyword changes in this PR. Bench skipped. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds the
Tlydetector todefaults.goand gates it behind the appropriate feature flag.Additionally, the PR updates the detector’s verification logic to align with the latest implementation changes.
Corpora Test
The detector appear in the list but on the lower side.

Checklist:
make test-community)?make lintthis requires golangci-lint)?Note
Low Risk
Adds a gated third-party API detector and changes verification HTTP behavior only for TLy; no auth or core scan pipeline changes.
Overview
This PR enables the TLy URL-shortener API key detector in the default engine and wires it behind a new
TlyDetectorEnabledfeature flag (on by default in OSSmain, same pattern as Pinecone/Cloudinary/GitLab OAuth).The
tlyscanner is refactored to dedupe matched keys, verify viaGET https://api.t.ly/api/v1/link/listwith a Bearer token (replacing the old query-token stats URL), record verification errors on results, and handle HTTP status codes explicitly. Integration tests switch from pretty to go-cmp with ignored verification/metadata fields.Reviewed by Cursor Bugbot for commit 24e4fd8. Bugbot is set up for automated code reviews on this repo. Configure here.