Improve YouTube API key verifier errors#5016
Open
srkyn wants to merge 1 commit into
Open
Conversation
|
|
| case http.StatusOK: | ||
| return true, nil | ||
| case http.StatusBadRequest, http.StatusUnauthorized, http.StatusForbidden: | ||
| return false, nil |
Contributor
There was a problem hiding this comment.
AFAIK, Google does return 403 for valid credentials that lack proper authorization. Could you double check this?
Error type Error detail Description
forbidden (403) forbidden Access forbidden. The request may not be properly authorized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improves the YouTube API key detector verifier by returning explicit verification errors for transport failures and unexpected API responses.
This is a narrow slice related to the detector verifier error-handling work discussed in #4051. The PR avoids closing keywords so the umbrella issue can stay open for the remaining detectors.
Changes
Tests