Improve behaviour of serve --open on listening errors #946#988
Open
silyevsk wants to merge 2 commits into
Open
Improve behaviour of serve --open on listening errors #946#988silyevsk wants to merge 2 commits into
serve --open on listening errors #946#988silyevsk wants to merge 2 commits into
Conversation
This addresses issue trunk-rs#946, but not completely fixes it: - for http and rustls, the page will open if and only if listening succeeds - for native-tls, the page will not open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses issue #946, but not completely fixes it:
I'm not sure this is a good solution: axum-server doesn't accept listener for native-tls and so it's not possible to do the same change as for http/rustls. We can make this change only for http/rustls and leave opening the page as before for native-tls, but that would complicate the code.