Skip to content

Display: sync resolution popups after a revert, fix stale last-good #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
armm77 wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −0
Open

Display: sync resolution popups after a revert, fix stale last-good #541

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions Applications/Preferences/Modules/Display/Display.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,6 +457,12 @@ - (void)screenDidChange:(NSNotification *)aNotif
if ([[activeResolution objectForKey:OSEDisplayResolutionNameKey]
isEqualToString:[oldResolution objectForKey:OSEDisplayResolutionNameKey]] != NO) {
NSLog(@"%s: Resolution has been reverted to last good. Keep it!", __func__);
// The display was reverted (Revert pressed or countdown expired). The
// resolution popup still shows the rejected resolution, so sync it and the
// refresh-rate popup back to the now-active resolution.
[resolutionBtn selectItemWithTitle:[activeResolution objectForKey:OSEDisplayResolutionNameKey]];
[self fillRateButton];
[self updateRateButton];
return;
}

Expand All @@ -480,6 +486,10 @@ - (void)screenDidChange:(NSNotification *)aNotif
}
} else {
NSLog(@"Keep current resoltuion.");
// Remember the kept resolution as the new "last good" so a subsequent
// revert returns here instead of to the resolution that was active before
// this change.
[lastGoodResolution setObject:activeResolution forKey:[selectedDisplay outputName]];
}
[alert release];
}
Expand Down
Loading