Skip to content

Commit 1c8b5b4

Browse files
authored
feat!: Upgrade Node.js dependencies (Actions and Supported versions) (#3498)
1 parent 8616e07 commit 1c8b5b4

10 files changed

Lines changed: 41 additions & 26 deletions

.github/workflows/build-and-test.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,16 +14,16 @@ jobs:
1414
strategy:
1515
fail-fast: false
1616
matrix:
17-
node: [ '20', '22', '24' ]
17+
node: [ '22', '24', '26' ]
1818

1919
name: Node ${{ matrix.node }} tests
2020

2121
steps:
2222
- name: Check out repository
23-
uses: actions/checkout@v4
23+
uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5.0.1
2424

2525
- name: Set up Node.js
26-
uses: actions/setup-node@v4
26+
uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5.0.0
2727
with:
2828
node-version: ${{ matrix.node }}
2929
cache: 'yarn'
@@ -42,10 +42,10 @@ jobs:
4242

4343
steps:
4444
- name: Check out repository
45-
uses: actions/checkout@v4
45+
uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5.0.1
4646

4747
- name: Set up Node.js
48-
uses: actions/setup-node@v4
48+
uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5.0.0
4949
with:
5050
node-version-file: '.node-version'
5151
cache: 'yarn'

.github/workflows/deploy-storybook.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,16 +22,16 @@ jobs:
2222
url: ${{ steps.build-publish.outputs.page_url }}
2323
steps:
2424
- name: Check out repository
25-
uses: actions/checkout@v4
25+
uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5.0.1
2626

2727
- name: Set up node
28-
uses: actions/setup-node@v4
28+
uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5.0.0
2929
with:
3030
node-version-file: '.node-version'
3131
cache: 'yarn'
3232

3333
- name: Deploy 🚀
34-
uses: bitovi/github-actions-storybook-to-github-pages@v1.0.3
34+
uses: bitovi/github-actions-storybook-to-github-pages@b75ece8f984a32b2adb322065d7a8a2cc8db2d52 # v1.0.3
3535
with:
3636
install_command: yarn install
3737
build_command: yarn build-storybook

.github/workflows/happo.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ jobs:
1515
happo:
1616
runs-on: ubuntu-latest
1717
steps:
18-
- uses: actions/checkout@v4
18+
- uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5.0.1
1919
with:
2020
ref: ${{ github.event.pull_request.head.sha || github.ref }}
2121
fetch-depth: 100
@@ -24,7 +24,7 @@ jobs:
2424
run: git fetch origin main:main
2525

2626
- name: Set up Node.js
27-
uses: actions/setup-node@v4
27+
uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5.0.0
2828
with:
2929
node-version-file: '.node-version'
3030
cache: 'yarn'

.github/workflows/package-release.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,10 @@ jobs:
1919

2020
steps:
2121
- name: Checkout out repository
22-
uses: actions/checkout@v4
22+
uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5.0.1
2323

2424
- name: Set up Node
25-
uses: actions/setup-node@v4
25+
uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5.0.0
2626
with:
2727
node-version-file: '.node-version'
2828
cache: 'yarn'
@@ -39,7 +39,7 @@ jobs:
3939
run: yarn pack --out trussworks-react-uswds-v%v.tgz
4040

4141
- name: Upload package
42-
uses: actions/upload-artifact@v4
42+
uses: actions/upload-artifact@330a01c490aca151604b8cf639adc76d48f6c5d4 # v5.0.0
4343
with:
4444
path: trussworks-react-uswds-v*.*.*.tgz
4545
if-no-files-found: error

.github/workflows/publish-next.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,18 +13,18 @@ jobs:
1313
name: Publish next to Github Packages
1414
steps:
1515
- name: Check out repository
16-
uses: actions/checkout@v4
16+
uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5.0.1
1717

1818
- name: Set up node
19-
uses: actions/setup-node@v4
19+
uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5.0.0
2020
with:
2121
node-version-file: '.node-version'
2222

2323
- name: Get yarn cache directory path
2424
id: yarn-cache-dir-path
2525
run: echo "dir='.yarn/cache'" >> $GITHUB_OUTPUT
2626

27-
- uses: actions/cache@v4
27+
- uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
2828
id: yarn-cache
2929
with:
3030
path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
@@ -38,7 +38,7 @@ jobs:
3838

3939
# Setup .npmrc file to publish to GitHub Packages
4040
- name: Set up node
41-
uses: actions/setup-node@v4
41+
uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5.0.0
4242
with:
4343
registry-url: 'https://npm.pkg.github.com'
4444
node-version-file: '.node-version'

.github/workflows/release-please.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
strategy:
1818
fail-fast: false
1919
steps:
20-
- uses: googleapis/release-please-action@v4
20+
- uses: googleapis/release-please-action@5c625bfb5d1ff62eadeeb3772007f7f66fdcf071 # v4.4.1
2121
with:
2222
config-file: "release-please-config.json"
2323
manifest-file: ".release-please-manifest.json"

.github/workflows/semantic_pr.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,13 @@ jobs:
1717
pull-requests: write
1818
steps:
1919
- id: lint_pr_title
20-
uses: amannn/action-semantic-pull-request@v6
20+
uses: amannn/action-semantic-pull-request@48f256284bd46cdaab1048c3721360e808335d50 # v6.1.1
2121
env:
2222
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
2323
with:
2424
wip: false
2525

26-
- uses: marocchino/sticky-pull-request-comment@v2
26+
- uses: marocchino/sticky-pull-request-comment@773744901bac0e8cbb5a0dc842800d45e9b2b405 # v2.9.4
2727
# Continue execution if action-semantic-pull-request fails with an error
2828
if: always() && (steps.lint_pr_title.outputs.error_message != null)
2929
with:
@@ -41,7 +41,7 @@ jobs:
4141
4242
# If the PR linting issue has been resolved, delete the corresponding comment if one exists
4343
- if: ${{ steps.lint_pr_title.outputs.error_message == null }}
44-
uses: marocchino/sticky-pull-request-comment@v2
44+
uses: marocchino/sticky-pull-request-comment@773744901bac0e8cbb5a0dc842800d45e9b2b405 # v2.9.4
4545
with:
4646
header: Invalid Pull Request Title
4747
delete: true

.node-version

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
24.11.0
1+
26.3.0

dangerfile.ts

Lines changed: 18 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -69,12 +69,27 @@ const checkYarnAudit: () => void = () => {
6969
'--json',
7070
])
7171
const output = result.stdout.toString()
72-
const summary = JSON.parse(output) as YawnAuditOutput
72+
73+
let summary: YawnAuditOutput
74+
try {
75+
summary = JSON.parse(output) as YawnAuditOutput
76+
} catch {
77+
// npm retired the audit endpoint Yarn 3 relies on (410 Gone), so the
78+
// command emits an error message instead of JSON. Skip the audit check
79+
// rather than failing every PR. Will be resolved in https://github.com/trussworks/react-uswds/pull/3500
80+
// by migrating to NPM.
81+
warn(
82+
'Unable to run `yarn npm audit` — the command did not return JSON ' +
83+
'(npm has retired the audit endpoint used by Yarn 3). ' +
84+
'Skipping the dependency audit check.'
85+
)
86+
return
87+
}
7388

7489
if (!summary.metadata?.vulnerabilities || !summary.advisories) {
7590
warn(
76-
`Unable to parse the yarn npm audit response.\n" +
77-
"dangerfile.ts likely needs updating`
91+
'Unable to parse the yarn npm audit response.\n' +
92+
'dangerfile.ts likely needs updating'
7893
)
7994
return
8095
}

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
"lib"
3434
],
3535
"engines": {
36-
"node": ">= 20"
36+
"node": ">= 22"
3737
},
3838
"scripts": {
3939
"test": "vitest --run",

0 commit comments

Comments
 (0)