Skip to content

fix(a11y): Set Pagination's last page aria-label to indicate that it is the last page#3499

Merged
brandonlenz merged 4 commits into
mainfrom
bl-last-page
Jun 22, 2026
Merged

fix(a11y): Set Pagination's last page aria-label to indicate that it is the last page#3499
brandonlenz merged 4 commits into
mainfrom
bl-last-page

Conversation

@brandonlenz

@brandonlenz brandonlenz commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Summary

Sets the aria-label of the last page to Last page, page ${the_page_number}

Side note: This component could use a lot of TLC to make it usable with a translation framework. I did not help with that in this PR, but will create an issue for the backlog.

Related Issues or PRs

closes: #3093

How To Test

  • Unit tests confirm this behavior
  • Can also verify in storybook on this branch

Screenshots (optional)

image

Author & Maintainer checklist

  • Is this is a breaking change?
    • Yes, and I accounted for the breaking changes according to the linked documentation
    • No
  • Once merged, add the PR and Issue author(s) as a contributor(s) via the all-contributors bot

@brandonlenz brandonlenz self-assigned this Jun 9, 2026
@brandonlenz brandonlenz requested a review from a team as a code owner June 9, 2026 19:46
@brandonlenz brandonlenz changed the title fix: Set Pagintion's last page aria-label to indicate that it is the last page fix: Set Pagination's last page aria-label to indicate that it is the last page Jun 9, 2026
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor
Warnings
⚠️ This PR does not include changes to storybook, even though it affects component code.

Generated by 🚫 dangerJS against a9b164f

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor test refactoring can be found in this file

@brandonlenz brandonlenz changed the title fix: Set Pagination's last page aria-label to indicate that it is the last page fix(a11y): Set Pagination's last page aria-label to indicate that it is the last page Jun 17, 2026

@ronaktruss ronaktruss left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread src/components/Pagination/Pagination.tsx Outdated
@brandonlenz brandonlenz merged commit 3b42cd9 into main Jun 22, 2026
9 checks passed
@brandonlenz brandonlenz deleted the bl-last-page branch June 22, 2026 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[fix] Add the ability for screen reader users to know that a page is the last page when navigating the Pagination component

2 participants