Skip to content

docs(storybook): Render Label examples within a usa-form for USWDS intended styling#3518

Merged
brandonlenz merged 2 commits into
mainfrom
2866-fix-storybook-label-styles
Jun 24, 2026
Merged

docs(storybook): Render Label examples within a usa-form for USWDS intended styling#3518
brandonlenz merged 2 commits into
mainfrom
2866-fix-storybook-label-styles

Conversation

@brandonlenz

@brandonlenz brandonlenz commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Summary

Related Issues or PRs

closes: #2866

How To Test

Storybook is the best way. Happo diff will show this clearly

Screenshots (optional)

image

Author & Maintainer checklist

  • Is this is a breaking change?
    • Yes, and I accounted for the breaking changes according to the linked documentation
    • No
  • Once merged, add the PR and Issue author(s) as a contributor(s) via the all-contributors bot

@brandonlenz brandonlenz requested a review from reggieriser June 22, 2026 14:45
@brandonlenz brandonlenz self-assigned this Jun 22, 2026
@brandonlenz brandonlenz requested a review from a team as a code owner June 22, 2026 14:45
@brandonlenz brandonlenz changed the title docs(storybook): Render Label examples within usa-form for USWDS intended styling docs(storybook): Render Label examples within a usa-form for USWDS intended styling Jun 22, 2026
@brandonlenz

Copy link
Copy Markdown
Contributor Author

Happo diffs across these elements due to container width changing with the addition of usa-form, but the asterisk is shown correctly there now too:

image

I approved them.

@reggieriser reggieriser left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brandonlenz brandonlenz enabled auto-merge (squash) June 24, 2026 13:42
@brandonlenz brandonlenz merged commit 506903e into main Jun 24, 2026
9 checks passed
@brandonlenz brandonlenz deleted the 2866-fix-storybook-label-styles branch June 24, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[docs] Storybook: odd styling for label with required marker

2 participants