fix: resolve char/u_char pointer-sign compiler warnings#426
Merged
thegushi merged 1 commit intoJun 20, 2026
Merged
Conversation
Adds explicit casts at the char*/u_char* boundary throughout libopendmarc and the milter, eliminating -Wpointer-sign and a stray nested-comment warning surfaced by a non-CI build (CI suppresses these via -Wno-pointer-sign). Also drops two backwards casts on dfc->mctx_jobid (char *) and fixes a real -Wincompatible-pointer-types mismatch in the ignorereceivers history path.
This was referenced Jun 20, 2026
thegushi
added a commit
that referenced
this pull request
Jun 20, 2026
thegushi
added a commit
to thegushi/OpenDMARC
that referenced
this pull request
Jun 21, 2026
Casts strdup() results back to u_char * for organizational_domain assignments in query_dmarc_psl, query_dmarc_rfc7489_walk, and query_dmarc_rfc9989_walk, matching the cast convention applied elsewhere in trusteddomainproject#426.
thegushi
added a commit
that referenced
this pull request
Jun 21, 2026
* feat: add DMARCbis walk mode selection (RFC 9989 DNS Tree Walk)
Refactor organizational domain discovery in libopendmarc into three
independently-callable walk strategies selectable at runtime via a new
DMARCbisWalkMode config option in opendmarc.conf.
- Add OPENDMARC_WALK_MODE_{AUTO,PSL,RFC7489,RFC9989} constants and walk_mode
field to OPENDMARC_LIB_T (dmarc.h.in)
- Add np= and psd= fields to DMARC_POLICY_T (opendmarc_internal.h)
- Extract dmarc_query_at(), psd_from_record(), query_dmarc_psl(),
query_dmarc_rfc7489_walk(), and query_dmarc_rfc9989_walk() from the
monolithic opendmarc_policy_query_dmarc(); dispatch by walk_mode
- Parse np= and psd= tags in opendmarc_policy_parse_dmarc()
- Wire DMARCbisWalkMode config key in opendmarc-config.h and opendmarc.c
- Document DMARCbisWalkMode in opendmarc.conf.sample and opendmarc.conf.5.in
- Add DMARCBIS-WALK-NOTES.txt capturing RFC 9989 open questions
AUTO mode preserves pre-DMARCbis behaviour (PSL if configured, label-strip
walk otherwise). No #ifdef compile-time gates.
* fix: discard multiple DMARC records at one name (RFC 7489 S 6.6.3, RFC 9989 S 4.10)
dmarc_dns_get_record() previously returned the first "v=DMARC" TXT record
found without checking for duplicates, silently violating the rule in both
RFCs that multiple valid DMARC records at a single DNS name must all be
discarded.
- Scan all TXT records in the answer before returning; count those
containing "v=DMARC". Return the record only when exactly one is found;
return NULL/NO_DATA when zero or more than one are found.
- Fix the fake DNS table path with the same count-before-returning logic.
- Fix a pre-existing cursor advancement bug: the non-DMARC TXT branch was
adding the already-consumed dn_expand name length a second time. Replace
ad-hoc cur_ptr arithmetic with an rdata_end pointer set from RDLENGTH.
- Add a fake-DNS test case: two v=DMARC1 entries for the same name must
yield DMARC_DNS_ERROR_NO_RECORD.
* feat(survey): check RFC 7489 S 7.1 external reporting consent in pct-survey
For every rua= and ruf= URI whose destination domain differs from the
policy domain, query {policy-domain}._report._dmarc.{dest-domain} and
flag any that lack a v=DMARC1 consent record.
- New output columns rua_bad / ruf_bad: comma-separated list of external
URIs missing consent, or "-" if none problematic
- Async consent-check phase after the main DNS loop, at full concurrency
- Same-domain and subdomain URIs skipped (no check needed)
- Output buffered until consent phase completes; then written in one pass
- Summary log gains rua_ext_bad / ruf_ext_bad columns for trend tracking
* fix: resolve pointer-sign warnings in DMARCbis walk-mode helpers
Casts strdup() results back to u_char * for organizational_domain
assignments in query_dmarc_psl, query_dmarc_rfc7489_walk, and
query_dmarc_rfc9989_walk, matching the cast convention applied
elsewhere in #426.
* docs: record AUTO-mode fallback scope decision in DMARCbis walk notes
Documents that AUTO mode's fallback to the RFC 7489 walk applies
whenever the PSL path fails, not only when no PSL boundary was found,
which is a deliberate broadening versus pre-refactor behavior.
---------
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-Wno-pointer-sign) surfaced ~240-Wpointer-signwarnings from the long-standingchar */u_char *mixing throughout libopendmarc and the milter, plus one stray nested-comment warning and one real-Wincompatible-pointer-typesmismatch.(u_char *)casts ondfc->mctx_jobid, which is actually declaredchar *./*inside an already-open block comment inopendmarc.c.ignorereceivershistory path where locally-scopedchar *user/domainwere passed to a function expectingunsigned char **.Test plan
makerebuild (libopendmarc, opendmarc milter w/ libmilter + libspf2, reports) with defaultCFLAGS(no-Wno-pointer-sign): 0 warnings, 0 errorslibopendmarc/tests:test_alignment,test_parse_to_buf,test_spf_parseall passopendmarc-check google.comruns correctly end-to-end