fix: resolve char/u_char pointer-sign warnings in libopendmarc test suite#427
Merged
thegushi merged 1 commit intoJun 20, 2026
Conversation
…uite make check surfaces the same -Wpointer-sign warnings as the main build once libmilter/libspf2 are on the include path. Also corrects test_dmarc_fetch.c, which declared opendmarc_policy_fetch_ruf/rua's return value as u_char * instead of the actual u_char ** (caught as -Wincompatible-pointer-types).
thegushi
added a commit
that referenced
this pull request
Jun 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #426. `make all` doesn't build `libopendmarc/tests/`, so `make check` surfaces its own set of `-Wpointer-sign` warnings once libmilter/libspf2 are on the include path. Same cast-based fix applied to 6 test files.
Also fixes a genuine bug caught by `-Wincompatible-pointer-types`: `test_dmarc_fetch.c` declared the return of `opendmarc_policy_fetch_ruf`/`opendmarc_policy_fetch_rua` as `u_char *`, but both functions actually return `u_char **`.
Test plan