feat: always log StaleMARC/suppressions-DB report skips#438
Merged
thegushi merged 1 commit intoJun 27, 2026
Merged
Conversation
Previously every skip reason (StaleMARC, the suppressions DB, and NoReportsList) was only printed under --verbose, so a report silently skipped via StaleMARC or the suppressions table left no trace in a normal cron run. NoReportsList stays --verbose-only since it's operator-curated and the operator already knows what's in it; the other two are dynamic/external and worth surfacing by default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--verbose, so a report silently dropped via StaleMARC or the suppressions table left no trace in a normal cron run.loud_skip()helper and wires it into all four skip print sites (aggregate domain-level, aggregate recipient-level, and both--forensicequivalents): StaleMARC and suppressions-DB skips are now always written to stderr, regardless of--verbose.NoReportsList/--skipdomainsskips remain--verbose-only, since that list is operator-curated and the operator already knows what's in it; making those loud too would just be noise for anyone using it heavily.REPORTING SUPPRESSIONSsection of the man page.Test plan
perl -con all report scripts (generated from.intemplates) — syntax OKloud_skip()returns true only for "StaleMARC"/"suppression DB" and false for both NoReportsList variantsmandoc