chore(deps): update module github.com/prometheus/client_golang to v1.24.0#1135
Merged
desmax74 merged 1 commit intoJul 23, 2026
Conversation
…24.0 Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the indirect dependency on github.com/prometheus/client_golang from v1.23.2 to v1.24.0 and drops an unused indirect dependency on github.com/klauspost/compress, picking up upstream API/behavioral changes and transitive dependency adjustments from the new Prometheus client release. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Since v1.24.0 of github.com/prometheus/client_golang now requires Go 1.25+, double-check that your go.mod
goversion and build pipelines are aligned with this minimum before merging. - Prometheus client v1.24.0 changes some APIs (e.g., name validation,
Rulesmatchers,LabelNamesreturn type); it’s worth scanning your codebase for usages of these to confirm there are no implicit breaking changes introduced by the upgrade.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since v1.24.0 of github.com/prometheus/client_golang now requires Go 1.25+, double-check that your go.mod `go` version and build pipelines are aligned with this minimum before merging.
- Prometheus client v1.24.0 changes some APIs (e.g., name validation, `Rules` matchers, `LabelNames` return type); it’s worth scanning your codebase for usages of these to confirm there are no implicit breaking changes introduced by the upgrade.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
desmax74
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
v1.23.2→v1.24.0Warning
Some dependencies could not be looked up. Check the warning logs for more information.
Release Notes
prometheus/client_golang (github.com/prometheus/client_golang)
v1.24.0: - 2026-07-20Compare Source
Changes
model.NameValidationSchemeglobal. Default behavior is unchanged; code that setNameValidationScheme = LegacyValidationno longer gets legacy enforcement at metric, label, and push-grouping construction. #2051matches[]parameter) inRulesmethod (Rules(ctx context.Context, matches []string) (RulesResult, error)). #1843LabelNamesmethod to returnmodel.LabelNamesinstead of[]stringfor consistency across the API. #1850Storeinterface, renameHandlertoWriteHandler, and encapsulate write response handling. #1855/sched/goroutines-created:goroutines,/sched/goroutines/not-in-go:goroutines,/sched/goroutines/runnable:goroutines,/sched/goroutines/running:goroutines,/sched/goroutines/waiting:goroutines,/sched/threads/total:threads). #1942WithUnit(unit string)option and explicit OpenMetrics unit support inCounterOpts,GaugeOpts,SummaryOpts, andHistogramOpts. #1392Err()method onDesc. #1902HandlerOpts.CoalesceGatherto deduplicate concurrentGathercalls so overlapping scrapes share one collection cycle, preventing goroutine pile-up when the scrape rate outpaces collection time. #1969promhttppackage now support metrics filtering by providing one or morename[]query parameters. The default behavior when none are provided remains the same, returning all metrics. #1925/format_query) andFormatQuery(ctx context.Context, query string) (string, error)method. #1846, #1856/status/tsdb/blocksendpoint viaTSDBBlocks(ctx context.Context) ([]TSDBBlock, error)method. #1896BackoffConfigto allow customization when usingWithAPIBackoff. #1895RetryCallBackto allow custom logging or handling on retry attempts in the remote write client. #1888, #1890http.DefaultTransportwhen constructing default HTTP clients to prevent accidental mutations of shared global transport state. #1885Gather()and return an error instead of crashing the process. #1961cpu-secondsunit suffix handling for metricgo_cpu_classes_gc_mark_assist_cpu_seconds. #1991InstrumentHandlerDurationandInstrumentHandlerCounterno longer panic when given an observer/counter that does not implementExemplarObserver/ExemplarAdder(e.g. aSummaryVec). The exemplar is dropped and the value is recorded via the plainObserve/Addpath, matching the safe-cast already used byTimer.ObserveDurationWithExemplar. #2005GETrequests whenPOSTrequests return403 Forbiddenor method not allowed. #2030httpClient.Do. #1971All commits
/status/tsdb/blocksendpoint by @tjhop in #1896/metricshandler output filtering vianame[]query param by @colega in #1925New Contributors
Full Changelog: prometheus/client_golang@v1.23.2...v1.24.0
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.
Summary by Sourcery
Build: