Hermetic builds -- use requirements.txt and remove poetry#15
Merged
m-misiura merged 1 commit intoNov 28, 2025
Merged
Conversation
…d remove poetry in favour of pip
| # langchain-community | ||
| langchain-community==0.3.29 | ||
| # via nemoguardrails (pyproject.toml) | ||
| langchain-core==0.3.76 |
Check failure
Code scanning / Trivy
langchain-core: LangChain Vulnerable to Template Injection via Attribute Access in Prompt Templates High
RobGeada
approved these changes
Nov 28, 2025
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #15 +/- ##
==========================================
Coverage ? 75.39%
==========================================
Files ? 186
Lines ? 18582
Branches ? 0
==========================================
Hits ? 14009
Misses ? 4573
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
c90cdd9
into
trustyai-explainability:develop
17 of 19 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For the hermetic builds, requirements.txt file is needed; this is not straightforward with poetry as
poetry exportfails with e.g.Moreover, there is no details where dependencies are coming from
To generate requirements.txt I used
uvinstead which in my view yields a much more informative file as it shows a trace of where each dependency is coming fromAdditionally, I removed the
poetryusage from the Containerfile and just usepipTest plan
Manually ran this demo using an image quay.io/rh-ee-mmisiura/nemo-guardrails:pip-models