OpenTelemetry auto-instrumentation support#39
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #39 +/- ##
==========================================
Coverage ? 76.88%
==========================================
Files ? 200
Lines ? 20412
Branches ? 0
==========================================
Hits ? 15693
Misses ? 4719
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
| export OTEL_SERVICE_NAME="${OTEL_SERVICE_NAME:-nemo-guardrails}" | ||
| exec opentelemetry-instrument "${CMD[@]}" | ||
| else | ||
| exec "${CMD[@]}" |
There was a problem hiding this comment.
Could we command inject this now via the $CONFIG_ID variable? Although we probably could before as well
There was a problem hiding this comment.
I would assume the risk is low, but perhaps validating CONFIG_ID so that it contains only safe characters (alphanumeric, hyphens, underscores) might be prudent? WDYT?
There was a problem hiding this comment.
I have added the input validation on CONFIG_ID and PORT
m-misiura
force-pushed
the
otel-instrument
branch
from
3017c8e to
2926872
Compare
…modules & changing the server entrypoint
m-misiura
force-pushed
the
otel-instrument
branch
from
2926872 to
812a437
Compare
m-misiura
merged commit 4c0d47f
into
trustyai-explainability:develop
3 participants
Description
OpenTelemetry auto-instrumentation support not working due to missing packages and entrypoint not being configured -- this has been rectified accordingly to address RHOAIENG-56965
Test plan