Skip to content

fix(server): Add tool calling params#56

Open
christinaexyou wants to merge 21 commits into
trustyai-explainability:developfrom
christinaexyou:update-chat-completions
Open

fix(server): Add tool calling params#56
christinaexyou wants to merge 21 commits into
trustyai-explainability:developfrom
christinaexyou:update-chat-completions

Conversation

@christinaexyou

Copy link
Copy Markdown

Cherry-pick of NeMo PR!1942

@github-advanced-security github-advanced-security AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bandit found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 92.18750% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.83%. Comparing base (e3dfba6) to head (eeb0519).
⚠️ Report is 122 commits behind head on develop.

Files with missing lines Patch % Lines
nemoguardrails/server/schemas/utils.py 92.59% 4 Missing ⚠️
nemoguardrails/server/api.py 85.71% 1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #56      +/-   ##
===========================================
+ Coverage    76.91%   79.83%   +2.92%     
===========================================
  Files          200      236      +36     
  Lines        20473    23936    +3463     
===========================================
+ Hits         15747    19110    +3363     
- Misses        4726     4826     +100     
Flag Coverage Δ
python 79.83% <92.18%> (+2.92%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
nemoguardrails/server/schemas/openai.py 100.00% <100.00%> (ø)
nemoguardrails/server/api.py 78.64% <85.71%> (+3.50%) ⬆️
nemoguardrails/server/schemas/utils.py 91.01% <92.59%> (+1.32%) ⬆️

... and 39 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

RobGeada
RobGeada previously approved these changes Jun 15, 2026
miyoungc and others added 15 commits June 15, 2026 10:27
…NeMo#2040)

Signed-off-by: Pouyanpi <13303554+Pouyanpi@users.noreply.github.com>
Signed-off-by: Pouyanpi <13303554+Pouyanpi@users.noreply.github.com>
…#2051)

Signed-off-by: Pouyanpi <13303554+Pouyanpi@users.noreply.github.com>
…IDIA-NeMo#1650)

closes  NVIDIA-NeMo#936

Co-authored-by: Awneesh <awneesh@Awneeshs-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants