Update provider spec & upgrade to llama-stack 0.2.22#17
Conversation
- Split into inline & remote modules. - Update `run-inline.yaml` and `run-remote.yaml` to include new APIs and adjust paths. - Remove deprecated provider YAML files and implement new inline and remote provider structures. - Modify inline and remote demo notebooks to reflect updated model identifiers and URLs.
saichandrapandraju
left a comment
There was a problem hiding this comment.
LGTM! Thanks @dmaniloff
nathan-weinberg
left a comment
There was a problem hiding this comment.
Generally this LGTM, but please wait for @cdoern for approve before merging
cdoern
left a comment
There was a problem hiding this comment.
comment about module usage, looks like its moving in the right direction!
|
@cdoern here's what @saichandrapandraju and i discussed, please let us know what you think: option 1: leave as-is, it will work.
option 2: make the default provider the remote one.
suggestion: given that we do provide a customized run.yaml i think for now option 1 is good, also taking in to account that you have your refactor in the queue to simplify this process. ps: as i write this i realize we also have a third option which combines both 1 & 2, by specifying the remote version of the provider as default (to be on the safe side so that top-level imports just work and also the auto-generated run.yaml works), and we fully specify the .inline and .remote in the yamls of the red hat lls distro to show how they can be selected. |
this way it is also an installable target.
cdoern
left a comment
There was a problem hiding this comment.
If this works, I am good with it.
I just want to confirm:
the build yaml module is llama_stack_provider_ragas. and then the run.yaml module will be llama_stack_provider_ragas.remote and this works, right?
|
Correct! And we will provide a default too, so that llama_stack_provider_ragas as a run module will work as well. |
| def get_provider_spec() -> ProviderSpec: | ||
| return remote_provider_spec( | ||
| api=Api.eval, | ||
| adapter=AdapterSpec( |
There was a problem hiding this comment.
a note. When you bump to 0.2.23+ this will break: ogx-ai/ogx#3378
|
@nathan-weinberg i will merge this, then release a new version, then update my comments to the correct version of llama_stack_provider_ragas in opendatahub-io/ogx-distribution#52 |
run-inline.yamlandrun-remote.yamlto include new APIs and adjust paths.