Skip to content

Update provider spec & upgrade to llama-stack 0.2.22#17

Merged
dmaniloff merged 8 commits into
trustyai-explainability:mainfrom
dmaniloff:update-provider-spec
Oct 1, 2025
Merged

Update provider spec & upgrade to llama-stack 0.2.22#17
dmaniloff merged 8 commits into
trustyai-explainability:mainfrom
dmaniloff:update-provider-spec

Conversation

@dmaniloff

@dmaniloff dmaniloff commented Sep 25, 2025

Copy link
Copy Markdown
Collaborator
  • Split into inline & remote modules.
  • Update run-inline.yaml and run-remote.yaml to include new APIs and adjust paths.
  • Remove deprecated provider YAML files and implement new inline and remote provider structures.
  • Modify inline and remote demo notebooks to reflect updated model identifiers and re-run w/ new LLS version.
  • Update tests & docs.
  • Version bump.

- Split into inline & remote modules.
- Update `run-inline.yaml` and `run-remote.yaml` to include new APIs and adjust paths.
- Remove deprecated provider YAML files and implement new inline and remote provider structures.
- Modify inline and remote demo notebooks to reflect updated model identifiers and URLs.
@dmaniloff dmaniloff changed the title Update to new llama-stack provider spec Update provider spec & upgrade to llama-stack 0.2.22 Sep 25, 2025

@saichandrapandraju saichandrapandraju left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @dmaniloff

@nathan-weinberg nathan-weinberg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally this LGTM, but please wait for @cdoern for approve before merging

Comment thread src/llama_stack_provider_ragas/inline/__init__.py

@cdoern cdoern left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment about module usage, looks like its moving in the right direction!

Comment thread src/llama_stack_provider_ragas/inline/provider.py
Comment thread src/llama_stack_provider_ragas/remote/provider.py
@dmaniloff

Copy link
Copy Markdown
Collaborator Author

@cdoern here's what @saichandrapandraju and i discussed, please let us know what you think:

option 1: leave as-is, it will work.

  • why? we currently specify the package name and version in build.yaml, that will pull in the provider package and install OK. i just re-tested w/ 0.2.22
  • we then specify the module in run.yaml and use the .inline / .remote specifications
  • the only issue w/ this approach is that the auto-generated run.yaml that results from running llama stack build will have module==package name which is incorrect. not ideal, but we are providing a custom run.yaml anyways.

option 2: make the default provider the remote one.

  • this means just adding a top-level provider.py and from there pointing to the default one. ie., from .remote.provider import get_provider_spec
  • add documentation in the package to explain to users that if they want the inline version they need to modify run.yaml to use .inline in the module arg.

suggestion: given that we do provide a customized run.yaml i think for now option 1 is good, also taking in to account that you have your refactor in the queue to simplify this process.

ps: as i write this i realize we also have a third option which combines both 1 & 2, by specifying the remote version of the provider as default (to be on the safe side so that top-level imports just work and also the auto-generated run.yaml works), and we fully specify the .inline and .remote in the yamls of the red hat lls distro to show how they can be selected.

this way it is also an installable target.

@cdoern cdoern left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this works, I am good with it.

I just want to confirm:

the build yaml module is llama_stack_provider_ragas. and then the run.yaml module will be llama_stack_provider_ragas.remote and this works, right?

Comment thread src/llama_stack_provider_ragas/provider.py
@dmaniloff

dmaniloff commented Oct 1, 2025

Copy link
Copy Markdown
Collaborator Author

Correct! And we will provide a default too, so that llama_stack_provider_ragas as a run module will work as well.

def get_provider_spec() -> ProviderSpec:
return remote_provider_spec(
api=Api.eval,
adapter=AdapterSpec(

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a note. When you bump to 0.2.23+ this will break: ogx-ai/ogx#3378

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#21

@dmaniloff

dmaniloff commented Oct 1, 2025

Copy link
Copy Markdown
Collaborator Author

@nathan-weinberg i will merge this, then release a new version, then update my comments to the correct version of llama_stack_provider_ragas in opendatahub-io/ogx-distribution#52

@dmaniloff dmaniloff merged commit 65c8b2f into trustyai-explainability:main Oct 1, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants