feat:Add Python naming specification to OpenAPI schema with x-stainless-naming#206
feat:Add Python naming specification to OpenAPI schema with x-stainless-naming#206
Conversation
WalkthroughA new Python-specific naming specification was added to the OpenAPI schema in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Note 🔌 MCP (Model Context Protocol) integration is now available in Early Access!Pro users can now connect to remote MCP servers under the Integrations page to get reviews and chat conversations that understand additional development context. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/libs/tryAGI.OpenAI/openapi.yaml (1)
10358-10361: Optional: document the intent inlineA short YAML comment helps future maintainers understand why explicit naming is required for Python.
x-stainless-go-variant-constructor: naming: 'chat_completion_{variant}_tool' + # Python-specific explicit names to stabilize SDK codegen x-stainless-naming: python: model_name: chat_completion_tool_union param_model_name: chat_completion_tool_union_param
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/libs/tryAGI.OpenAI/openapi.yaml(1 hunks)
🔇 Additional comments (2)
src/libs/tryAGI.OpenAI/openapi.yaml (2)
10358-10361: Explicit Python naming looks good and reduces codegen driftDefining python.model_name and python.param_model_name under x-stainless-naming is clear and consistent with vendor-extension style. Good move to stabilize generated class names.
10358-10361: ✅ Unique Python names confirmed, generator compatibility pending– Checked
chat_completion_tool_union&chat_completion_tool_union_paramunder
components/schemas/CreateChatCompletionRequest/allOf/1/properties/tools/items;
no duplicates elsewhere in the schema.
– No othermodel_nameorparam_model_namecollisions detected.Next step: please verify that the Stainless code generator supports the Python keys
x-stainless-naming.python.model_nameandx-stainless-naming.python.param_model_name
so these custom names are applied correctly.
Summary by CodeRabbit