Skip to content

chore: Remove unnecessary drop calls #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marc2332 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: Remove unnecessary drop calls #220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion crates/cli/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,7 +474,6 @@ fn run_main() -> CliResult<()> {
Command::Config { action } => handle_config_command(action),
}
})();
drop(_tokio_guard);
nova_result
}

Expand Down
1 change: 0 additions & 1 deletion crates/runtime/src/ext/broadcast_channel/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ impl BroadcastChannelExt {
let mut next_rid = NEXT_RID.lock().unwrap();
let rid = *next_rid;
*next_rid += 1;
drop(next_rid);

Ok(Value::from_f64(agent, rid as f64, gc.nogc()).unbind())
}
Expand Down
5 changes: 0 additions & 5 deletions crates/runtime/src/ext/canvas/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2255,7 +2255,6 @@ impl CanvasExt {
.filter(|s| s.points.len() >= 3)
.map(|s| s.points.clone())
.collect();
drop(path);

if let Some(mut renderer) = res.renderers.get_mut(canvas_rid) {
let data = res.canvases.get(canvas_rid).unwrap();
Expand Down Expand Up @@ -2318,7 +2317,6 @@ impl CanvasExt {
pts
})
.collect();
drop(path);

if let Some(mut renderer) = res.renderers.get_mut(canvas_rid) {
let data = res.canvases.get(canvas_rid).unwrap();
Expand Down Expand Up @@ -2389,7 +2387,6 @@ impl CanvasExt {
.iter()
.find(|s| s.points.len() >= 3)
.map(|s| s.points.clone());
drop(path);

if let Some(points) = first
&& let Some(mut renderer) = res.renderers.get_mut(canvas_rid)
Expand Down Expand Up @@ -2423,7 +2420,6 @@ impl CanvasExt {
.into_iter()
.map(|(s, e)| data.current_path[s..e].to_vec())
.find(|s| s.len() >= 3);
drop(data);
if let Some(points) = first_subpath
&& let Some(mut renderer) = res.renderers.get_mut(rid)
{
Expand Down Expand Up @@ -3798,7 +3794,6 @@ impl CanvasExt {
drop(storage); // Drop the borrow before creating the string
return Ok(Value::from_string(agent, json, gc.nogc()).unbind());
}
drop(storage); // Drop the borrow

Ok(Value::Undefined)
}
Expand Down
2 changes: 0 additions & 2 deletions crates/runtime/src/ext/workers/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,6 @@ impl WorkersExt {
if let Some(record) = workers.remove(&id) {
record.terminate_flag.store(true, Ordering::Release);
let _ = record.tx_inbound.send(WorkerInbound::Terminate);
drop(record);
}
});

Expand Down Expand Up @@ -568,7 +567,6 @@ fn run_worker_thread(
});
terminate_flag.store(true, Ordering::Release);
}
drop(tx_outbound);

if entry_failed {
clear_leaked_outbound(leaked_host_hooks);
Expand Down
Loading