[dev] [carhartlewis] lewis/comp-form-type-finding-fix (#2159)

* test(finding-notifier): add unit tests for FindingNotifierService

* feat(taskEvidence): add mapping function for evidence form type conversion

* chore: update dependencies and improve evidence form handling

* feat(company): add @trycompai/db dependency and refactor evidence form type functions

---------

Co-authored-by: Lewis Carhart <lewis@trycomp.ai>

Author: github-actions[bot]

apps/api/package.json

@@ -82,6 +82,7 @@
         "prettier": "^3.5.3",
         "source-map-support": "^0.5.21",
         "supertest": "^7.0.0",
+        "trigger.dev": "4.0.6",
         "ts-jest": "^29.2.5",
         "ts-loader": "^9.5.2",
         "ts-node": "^10.9.2",
@@ -111,9 +112,9 @@
         "db:getschema": "node ../../packages/db/scripts/combine-schemas.js && cp ../../packages/db/dist/schema.prisma prisma/schema.prisma",
         "db:migrate": "cd ../../packages/db && bunx prisma migrate dev && cd ../../apps/api",
         "deploy:trigger-prod": "npx trigger.dev@4.0.6 deploy",
-        "dev": "bunx concurrently --kill-others --names \"nest,trigger\" --prefix-colors \"green,blue\" \"nest start --watch\" \"bunx trigger.dev@4.0.6 dev\"",
+        "dev": "bunx concurrently --kill-others --names \"nest,trigger\" --prefix-colors \"green,blue\" \"nest start --watch\" \"trigger dev\"",
         "dev:nest": "nest start --watch",
-        "dev:trigger": "bunx trigger.dev@4.0.6 dev",
+        "dev:trigger": "trigger dev",
         "format": "prettier --write \"src/**/*.ts\" \"test/**/*.ts\"",
         "lint": "eslint \"{src,apps,libs,test}/**/*.ts\" --fix",
         "prebuild": "bun run db:generate",

apps/api/src/evidence-forms/evidence-form-type-map.ts

@@ -1,6 +1,10 @@
 import { AttachmentsService } from '@/attachments/attachments.service';
 import type { AuthContext } from '@/auth/types';
-import { db, type EvidenceFormType as DbEvidenceFormType } from '@trycompai/db';
+import { db, EvidenceFormType as DbEvidenceFormType } from '@trycompai/db';
+import {
+  toDbEvidenceFormType,
+  toExternalEvidenceFormType,
+} from '@comp/company';
 import {
   BadRequestException,
   Injectable,
@@ -16,10 +20,6 @@ import {
   type EvidenceFormFieldDefinition,
   type EvidenceFormType,
 } from './evidence-forms.definitions';
-import {
-  toDbEvidenceFormType,
-  toExternalEvidenceFormType,
-} from './evidence-form-type-map';
 
 const listQuerySchema = z.object({
   search: z.string().trim().optional(),

apps/api/src/evidence-forms/evidence-forms.service.ts

@@ -7,19 +7,19 @@ import {
 } from '@nestjs/common';
 import {
   db,
-  type EvidenceFormType as DbEvidenceFormType,
+  EvidenceFormType as DbEvidenceFormType,
   FindingStatus,
   FindingType,
 } from '@trycompai/db';
+import {
+  toDbEvidenceFormType,
+  toExternalEvidenceFormType,
+} from '@comp/company';
 import { CreateFindingDto } from './dto/create-finding.dto';
 import { UpdateFindingDto } from './dto/update-finding.dto';
 import { FindingAuditService } from './finding-audit.service';
 import { FindingNotifierService } from './finding-notifier.service';
 import { type EvidenceFormType } from '@/evidence-forms/evidence-forms.definitions';
-import {
-  toDbEvidenceFormType,
-  toExternalEvidenceFormType,
-} from '@/evidence-forms/evidence-form-type-map';
 
 @Injectable()
 export class FindingsService {

apps/api/src/findings/findings.service.ts

@@ -145,6 +145,7 @@
         "postcss": "^8.5.4",
         "raw-loader": "^4.0.2",
         "tailwindcss": "^4.1.8",
+        "trigger.dev": "4.0.6",
         "typescript": "^5.8.3",
         "vite-tsconfig-paths": "^5.1.4",
         "vitest": "^3.2.4"
@@ -170,7 +171,7 @@
         "db:getschema": "node ../../packages/db/scripts/combine-schemas.js && cp ../../packages/db/dist/schema.prisma prisma/schema.prisma",
         "db:migrate": "cd ../../packages/db && bunx prisma migrate dev && cd ../../apps/app",
         "deploy:trigger-prod": "npx trigger.dev@4.0.6 deploy",
-        "dev": "bun i && bunx concurrently --kill-others --names \"next,trigger\" --prefix-colors \"yellow,blue\" \"next dev --turbo -p 3000\" \"bunx trigger.dev@4.0.6 dev\"",
+        "dev": "bun i && bunx concurrently --kill-others --names \"next,trigger\" --prefix-colors \"yellow,blue\" \"next dev --turbo -p 3000\" \"trigger dev\"",
         "lint": "eslint . && prettier --check .",
         "prebuild": "bun run db:generate",
         "postinstall": "prisma generate --schema=./prisma/schema.prisma || exit 0",