fix: Enable 'Ready for Review' menu for client on Document Finding (#2404)

* fix(app): pass isPlatformAdmin value to FindingItem to make 'Ready for Review' enabled by client

* fix(app): remove isAuditor and add canSetReadyForReview param to FindingItem

* fix(app): remove isPlatformAdmin prop from FindingItem

---------

Co-authored-by: chasprowebdev <chasgarciaprowebdev@gmail.com>
Co-authored-by: Mariano Fuentes <marfuen98@gmail.com>

Author: 3 people

apps/app/src/app/(app)/[orgId]/documents/[formType]/page.tsx

@@ -4,6 +4,8 @@ import Link from 'next/link';
 import { notFound } from 'next/navigation';
 import { Suspense } from 'react';
 import { evidenceFormDefinitions, evidenceFormTypeSchema } from '../forms';
+import { auth } from '@/utils/auth';
+import { headers } from 'next/headers';
 
 export default async function CompanyFormDetailPage({
   params,
@@ -19,6 +21,16 @@ export default async function CompanyFormDetailPage({
 
   const formDefinition = evidenceFormDefinitions[parsedType.data];
 
+  let isPlatformAdmin = false;
+
+  const session = await auth.api.getSession({
+    headers: await headers(),
+  });
+
+  if (session?.user?.id) {
+    isPlatformAdmin = session.user.role === 'admin';
+  }
+
   return (
     <PageLayout>
       <Breadcrumb
@@ -35,6 +47,7 @@ export default async function CompanyFormDetailPage({
         <CompanyFormPageClient
           organizationId={orgId}
           formType={parsedType.data}
+          isPlatformAdmin={isPlatformAdmin}
         />
       </Suspense>
     </PageLayout>

apps/app/src/app/(app)/[orgId]/documents/components/CompanyFormPageClient.tsx

@@ -145,7 +145,7 @@ async function evidenceFormFetcher([endpoint, orgId]: readonly [
 export function CompanyFormPageClient({
   organizationId,
   formType,
-  isPlatformAdmin,
+  isPlatformAdmin = false,
 }: {
   organizationId: string;
   formType: EvidenceFormType;
@@ -579,7 +579,7 @@ export function CompanyFormPageClient({
           </TabsContent>
 
           <TabsContent value="findings">
-            <DocumentFindingsSection formType={formType} />
+            <DocumentFindingsSection formType={formType} isPlatformAdmin={isPlatformAdmin} />
           </TabsContent>
         </Stack>
       </Tabs>

apps/app/src/app/(app)/[orgId]/documents/components/DocumentFindingsSection.tsx

@@ -25,10 +25,12 @@ const STATUS_ORDER: Record<FindingStatus, number> = {
 
 interface DocumentFindingsSectionProps {
   formType: EvidenceFormType;
+  isPlatformAdmin?: boolean;
 }
 
 export function DocumentFindingsSection({
   formType,
+  isPlatformAdmin = false,
 }: DocumentFindingsSectionProps) {
   const { hasPermission } = usePermissions();
   const { data: activeMember } = useActiveMember();
@@ -226,11 +228,10 @@ export function DocumentFindingsSection({
               <FindingItem
                 key={finding.id}
                 finding={finding}
-                isAuditor={canSetRestrictedStatus}
-                isPlatformAdmin={false}
                 isExpanded={expandedId === finding.id}
                 canChangeStatus={canChangeStatus}
                 canSetRestrictedStatus={canSetRestrictedStatus}
+                canSetReadyForReview={isPlatformAdmin || !canSetRestrictedStatus}
                 onToggleExpand={() => setExpandedId(expandedId === finding.id ? null : finding.id)}
                 onStatusChange={(status, revisionNote) =>
                   handleStatusChange(finding.id, status, revisionNote)

apps/app/src/app/(app)/[orgId]/tasks/[taskId]/components/findings/FindingItem.tsx

@@ -37,9 +37,8 @@ interface FindingItemProps {
   isExpanded: boolean;
   canChangeStatus: boolean;
   canSetRestrictedStatus: boolean;
+  canSetReadyForReview: boolean;
   canDelete?: boolean;
-  isAuditor: boolean;
-  isPlatformAdmin: boolean;
   isTarget?: boolean; // Whether this finding is the navigation target
   onToggleExpand: () => void;
   onStatusChange: (status: FindingStatus, revisionNote?: string) => Promise<void> | void;
@@ -55,9 +54,8 @@ export function FindingItem({
   isExpanded,
   canChangeStatus,
   canSetRestrictedStatus,
+  canSetReadyForReview,
   canDelete = canSetRestrictedStatus,
-  isAuditor,
-  isPlatformAdmin,
   isTarget = false,
   onToggleExpand,
   onStatusChange,
@@ -152,8 +150,6 @@ export function FindingItem({
   // - Auditors can set: open, needs_revision, closed
   // - Non-auditor admins/owners can set: open, ready_for_review
   const statusOptions = useMemo(() => {
-    const canSetReadyForReview = isPlatformAdmin || !isAuditor;
-
     return [
       { value: FindingStatus.open, label: 'Open', disabled: false },
       {
@@ -175,7 +171,7 @@ export function FindingItem({
         hint: !canSetRestrictedStatus ? 'Auditor only' : undefined,
       },
     ];
-  }, [isPlatformAdmin, isAuditor, canSetRestrictedStatus]);
+  }, [canSetRestrictedStatus, canSetReadyForReview]);
 
   return (
     <div

apps/app/src/app/(app)/[orgId]/tasks/[taskId]/components/findings/FindingsList.tsx

@@ -197,12 +197,11 @@ export function FindingsList({
               <FindingItem
                 key={finding.id}
                 finding={finding}
-                isAuditor={isAuditor}
-                isPlatformAdmin={isPlatformAdmin}
                 isExpanded={expandedId === finding.id}
                 isTarget={targetFindingId === finding.id}
                 canChangeStatus={canChangeStatus}
                 canSetRestrictedStatus={canSetRestrictedStatus}
+                canSetReadyForReview={isPlatformAdmin || !isAuditor}
                 canDelete={canDeleteFinding}
                 onToggleExpand={() => setExpandedId(expandedId === finding.id ? null : finding.id)}
                 onStatusChange={(status, revisionNote) =>