refactor(ui): improve Carbon nav icons + remove overview drag-and-drop (#2218)

* refactor(ui): improve nav icons + remove overview drag-and-drop

Icons (AppShellWrapper — rail):
- Compliance: CertificateCheck → Badge (certification badge)
- Trust:      CloudAuditing   → Globe (public/global trust center)
- Security:   Security        → ManageProtection (protection management)

Icons (AppSidebar — compliance sidebar):
- Auditor View:  TaskComplete → DocumentSigned  (auditors sign off)
- Controls:      Security     → SettingsAdjust  (adjustable params, no dupe)
- Documents:     Catalog      → FolderDetails   (folder of docs)
- People:        Group        → UserMultiple     (standard multi-user)
- Risks:         Warning      → Scale           (weighing risk)
- Vendors:       ShoppingBag  → Partnership     (business partners)
- Questionnaire: Document     → DocumentTasks   (task-filled form)
- Integrations:  Integration  → Connect         (connecting systems)
- Cloud Tests:   Chemistry    → TestTool        (test tooling)

Overview:
- Replace <DraggableCards> with a plain 2-column grid
- Delete DraggableCards.tsx, SortableCard.tsx, useCardOrder.ts

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* revert(ui): restore original compliance sidebar icons

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix(billing): look up run by providerRunId not internal id

The id returned by the create API is the provider run ID stored
in providerRunId, not the internal ptr... primary key.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: claudfuen

apps/app/src/app/(app)/[orgId]/components/AppShellWrapper.tsx

@@ -7,7 +7,7 @@ import { NotificationBell } from '@/components/notifications/notification-bell';
 import { OrganizationSwitcher } from '@/components/organization-switcher';
 import { SidebarProvider, useSidebar } from '@/context/sidebar-context';
 import { authClient } from '@/utils/auth-client';
-import { CertificateCheck, CloudAuditing, Logout, Security, Settings } from '@carbon/icons-react';
+import { Badge, Globe, Logout, ManageProtection, Settings } from '@carbon/icons-react';
 import {
   DropdownMenu,
   DropdownMenuContent,
@@ -240,22 +240,22 @@ function AppShellWrapperContent({
             <ShellRailNavItem
               href={`/${organization.id}/frameworks`}
               isActive={!isSettingsActive && !isTrustActive && !isSecurityActive}
-              icon={<CertificateCheck className="size-5" />}
+              icon={<Badge className="size-5" />}
               label="Compliance"
             />
             {isTrustNdaEnabled && (
               <ShellRailNavItem
                 href={`/${organization.id}/trust`}
                 isActive={isTrustActive}
-                icon={<CloudAuditing className="size-5" />}
+                icon={<Globe className="size-5" />}
                 label="Trust"
               />
             )}
             {isSecurityEnabled ? (
               <ShellRailNavItem
                 href={`/${organization.id}/security`}
                 isActive={isSecurityActive}
-                icon={<Security className="size-5" />}
+                icon={<ManageProtection className="size-5" />}
                 label="Security"
               />
             ) : null}

apps/app/src/app/(app)/[orgId]/frameworks/components/DraggableCards.tsx

@@ -3,7 +3,6 @@
 import { Finding, FrameworkEditorFramework, Policy, Task } from '@db';
 import { FrameworkInstanceWithControls } from '../types';
 import { ComplianceOverview } from './ComplianceOverview';
-import { DraggableCards } from './DraggableCards';
 import { FindingsOverview } from './FindingsOverview';
 import { FrameworksOverview } from './FrameworksOverview';
 import { ToDoOverview } from './ToDoOverview';
@@ -84,7 +83,7 @@ export const Overview = ({
   });
 
   return (
-    <DraggableCards>
+    <div className="grid grid-cols-1 gap-6 md:grid-cols-2">
       <ComplianceOverview
         organizationId={organizationId}
         overallComplianceScore={overallComplianceScore}
@@ -119,7 +118,7 @@ export const Overview = ({
         onboardingTriggerJobId={onboardingTriggerJobId}
       />
       <FindingsOverview findings={findings} organizationId={organizationId} />
-    </DraggableCards>
+    </div>
   );
 };
 

apps/app/src/app/(app)/[orgId]/frameworks/components/Overview.tsx

@@ -206,8 +206,9 @@ export async function checkAndChargePentestBilling(orgId: string, runId: string)
   await requireOrgMember(orgId);
 
   // Verify the run exists and belongs to this org to prevent arbitrary runId abuse.
+  // runId here is the provider run ID (stored in providerRunId), not the internal ptr... key.
   const run = await db.securityPenetrationTestRun.findUnique({
-    where: { id: runId },
+    where: { providerRunId: runId },
     select: { organizationId: true },
   });
   if (!run || run.organizationId !== orgId) {