Skip to content

Commit 409be26

Browse files
carhartlewisclaude
andcommitted
fix(frameworks): remove debug log and return DB-reported link counts
- Drop the per-request console.log in the requirement page that was dumping internal API status/error payloads into server logs - Return result.count from createMany in linkRequirements, linkControlsToRequirement, and linkDocumentTypes so skipDuplicates-skipped rows no longer inflate the reported count Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 9f1a8cc commit 409be26

3 files changed

Lines changed: 6 additions & 15 deletions

File tree

apps/api/src/controls/controls.service.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -417,7 +417,7 @@ export class ControlsService {
417417
throw new BadRequestException('No valid requirements to link');
418418
}
419419

420-
await db.requirementMap.createMany({
420+
const result = await db.requirementMap.createMany({
421421
data: validMappings.map((m) => ({
422422
controlId,
423423
frameworkInstanceId: m.frameworkInstanceId,
@@ -427,7 +427,7 @@ export class ControlsService {
427427
skipDuplicates: true,
428428
});
429429

430-
return { count: validMappings.length };
430+
return { count: result.count };
431431
}
432432

433433
async linkDocumentTypes(
@@ -436,11 +436,11 @@ export class ControlsService {
436436
formTypes: EvidenceFormType[],
437437
) {
438438
await this.ensureControl(controlId, organizationId);
439-
await db.controlDocumentType.createMany({
439+
const result = await db.controlDocumentType.createMany({
440440
data: formTypes.map((formType) => ({ controlId, formType })),
441441
skipDuplicates: true,
442442
});
443-
return { count: formTypes.length };
443+
return { count: result.count };
444444
}
445445

446446
async unlinkDocumentType(

apps/api/src/frameworks/frameworks.service.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -395,7 +395,7 @@ export class FrameworksService {
395395
throw new BadRequestException('No valid controls to link');
396396
}
397397

398-
await db.requirementMap.createMany({
398+
const result = await db.requirementMap.createMany({
399399
data: controls.map((c) => ({
400400
controlId: c.id,
401401
frameworkInstanceId,
@@ -406,7 +406,7 @@ export class FrameworksService {
406406
skipDuplicates: true,
407407
});
408408

409-
return { count: controls.length };
409+
return { count: result.count };
410410
}
411411

412412
async getScores(organizationId: string, userId?: string) {

apps/app/src/app/(app)/[orgId]/frameworks/[frameworkInstanceId]/requirements/[requirementKey]/page.tsx

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -29,15 +29,6 @@ export default async function RequirementPage({ params }: PageProps) {
2929
),
3030
]);
3131

32-
console.log('[RequirementPage]', {
33-
frameworkInstanceId,
34-
requirementKey,
35-
frameworkStatus: frameworkRes.status,
36-
frameworkError: frameworkRes.error,
37-
requirementStatus: requirementRes.status,
38-
requirementError: requirementRes.error,
39-
});
40-
4132
if (!frameworkRes.data || !requirementRes.data) {
4233
redirect(`/${organizationId}/frameworks/${frameworkInstanceId}`);
4334
}

0 commit comments

Comments
 (0)