Merge pull request #2543 from trycompai/cs-241-framework-dropdown

CS-241: Add all frameworks to finding type dropdown

Author: tofikwest

apps/app/src/app/(app)/[orgId]/tasks/[taskId]/components/findings/CreateFindingSheet.test.tsx

@@ -32,6 +32,15 @@ vi.mock('@/hooks/use-findings-api', () => ({
     },
   ],
   FINDING_CATEGORY_LABELS: { general: 'General' },
+  FINDING_TYPE_FRAMEWORK_OPTIONS: [
+    { value: 'soc2', label: 'SOC 2' },
+    { value: 'iso27001', label: 'ISO 27001' },
+    { value: 'pci_dss', label: 'PCI DSS' },
+    { value: 'hipaa', label: 'HIPAA' },
+    { value: 'gdpr', label: 'GDPR' },
+    { value: 'iso9001', label: 'ISO 9001' },
+    { value: 'iso42001', label: 'ISO 42001' },
+  ],
   FINDING_TYPE_LABELS: { soc2: 'SOC 2', iso27001: 'ISO 27001' },
   useFindingActions: () => ({
     createFinding: vi.fn(),
@@ -99,7 +108,14 @@ vi.mock('@trycompai/design-system', () => ({
   Select: ({ children }: any) => <div>{children}</div>,
   SelectContent: ({ children }: any) => <div>{children}</div>,
   SelectGroup: ({ children }: any) => <div>{children}</div>,
-  SelectItem: ({ children }: any) => <div>{children}</div>,
+  SelectItem: ({ children, value, disabled }: any) => (
+    <div
+      data-testid={`select-item-${value}`}
+      data-disabled={disabled ? 'true' : 'false'}
+    >
+      {children}
+    </div>
+  ),
   SelectLabel: ({ children }: any) => <div>{children}</div>,
   SelectTrigger: ({ children }: any) => <button>{children}</button>,
   Sheet: ({ children, open }: any) => (open ? <div data-testid="sheet">{children}</div> : null),
@@ -189,4 +205,32 @@ describe('CreateFindingSheet permission gating', () => {
 
     expect(screen.queryByTestId('sheet')).not.toBeInTheDocument();
   });
+
+  it('shows all required frameworks in finding type dropdown options', () => {
+    setMockPermissions(ADMIN_PERMISSIONS);
+
+    render(<CreateFindingSheet {...defaultProps} />);
+
+    expect(screen.getByText('SOC 2')).toBeInTheDocument();
+    expect(screen.getByText('ISO 27001')).toBeInTheDocument();
+    expect(screen.getByText('PCI DSS')).toBeInTheDocument();
+    expect(screen.getByText('HIPAA')).toBeInTheDocument();
+    expect(screen.getByText('GDPR')).toBeInTheDocument();
+    expect(screen.getByText('ISO 9001')).toBeInTheDocument();
+    expect(screen.getByText('ISO 42001')).toBeInTheDocument();
+  });
+
+  it('only enables framework options currently supported by FindingType enum', () => {
+    setMockPermissions(ADMIN_PERMISSIONS);
+
+    render(<CreateFindingSheet {...defaultProps} />);
+
+    expect(screen.getByTestId('select-item-soc2')).toHaveAttribute('data-disabled', 'false');
+    expect(screen.getByTestId('select-item-iso27001')).toHaveAttribute('data-disabled', 'false');
+    expect(screen.getByTestId('select-item-pci_dss')).toHaveAttribute('data-disabled', 'true');
+    expect(screen.getByTestId('select-item-hipaa')).toHaveAttribute('data-disabled', 'true');
+    expect(screen.getByTestId('select-item-gdpr')).toHaveAttribute('data-disabled', 'true');
+    expect(screen.getByTestId('select-item-iso9001')).toHaveAttribute('data-disabled', 'true');
+    expect(screen.getByTestId('select-item-iso42001')).toHaveAttribute('data-disabled', 'true');
+  });
 });

apps/app/src/app/(app)/[orgId]/tasks/[taskId]/components/findings/CreateFindingSheet.tsx

@@ -3,6 +3,7 @@
 import {
   DEFAULT_FINDING_TEMPLATES,
   FINDING_CATEGORY_LABELS,
+  FINDING_TYPE_FRAMEWORK_OPTIONS,
   FINDING_TYPE_LABELS,
   useFindingActions,
   useFindingTemplates,
@@ -68,6 +69,7 @@ export function CreateFindingSheet({
   const [isSubmitting, setIsSubmitting] = useState(false);
   const { hasPermission } = usePermissions();
   const canCreateFinding = hasPermission('finding', 'create');
+  const supportedFindingTypes = new Set(Object.values(FindingType));
 
   const { data: templatesData } = useFindingTemplates();
   const { createFinding } = useFindingActions();
@@ -165,8 +167,12 @@ export function CreateFindingSheet({
               <Select value={field.value} onValueChange={field.onChange}>
                 <SelectTrigger>{FINDING_TYPE_LABELS[field.value as FindingType]}</SelectTrigger>
                 <SelectContent>
-                  {Object.entries(FINDING_TYPE_LABELS).map(([value, label]) => (
-                    <SelectItem key={value} value={value}>
+                  {FINDING_TYPE_FRAMEWORK_OPTIONS.map(({ value, label }) => (
+                    <SelectItem
+                      key={value}
+                      value={value}
+                      disabled={!supportedFindingTypes.has(value as FindingType)}
+                    >
                       {label}
                     </SelectItem>
                   ))}

apps/app/src/hooks/use-findings-api.ts

@@ -395,6 +395,19 @@ export const FINDING_STATUS_CONFIG: Record<
   },
 };
 
+/**
+ * Framework options shown in finding type selectors
+ */
+export const FINDING_TYPE_FRAMEWORK_OPTIONS = [
+  { value: 'soc2', label: 'SOC 2' },
+  { value: 'iso27001', label: 'ISO 27001' },
+  { value: 'pci_dss', label: 'PCI DSS' },
+  { value: 'hipaa', label: 'HIPAA' },
+  { value: 'gdpr', label: 'GDPR' },
+  { value: 'iso9001', label: 'ISO 9001' },
+  { value: 'iso42001', label: 'ISO 42001' },
+] as const;
+
 /**
  * Finding type labels
  */