fix(people): restore isActive when re-inviting deactivated contractor (#2801)

addEmployeeWithoutInvite only set deactivated=false when reactivating,
leaving isActive=false — making the member invisible on the People page.
Also fix reactivateById to handle the isActive=false+deactivated=false
limbo state, and add missing Contractor option to role filter dropdown.

Closes CS-376

Co-authored-by: Mariano <marfuen98@gmail.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: 3 people

apps/api/src/people/people-invite.service.ts

@@ -170,11 +170,11 @@ export class PeopleInviteService {
     let isNewMember = false;
 
     if (existingMember) {
-      if (existingMember.deactivated) {
+      if (existingMember.deactivated || !existingMember.isActive) {
         const roleString = [...roles].sort().join(',');
         member = await db.member.update({
           where: { id: existingMember.id },
-          data: { deactivated: false, role: roleString },
+          data: { deactivated: false, isActive: true, role: roleString },
         });
       } else {
         member = existingMember;

apps/api/src/people/people.service.ts

@@ -448,16 +448,16 @@ export class PeopleService {
       organizationId,
     );
 
-    if (member) {
+    if (member && member.isActive) {
       throw new BadRequestException('Member is already active');
     }
 
-    // Look for deactivated member
-    const deactivatedMember = await db.member.findFirst({
+    // Look for inactive or deactivated member
+    const inactiveMember = await db.member.findFirst({
       where: { id: memberId, organizationId },
     });
 
-    if (!deactivatedMember) {
+    if (!inactiveMember) {
       throw new NotFoundException(
         `Member with ID ${memberId} not found in organization ${organizationId}`,
       );

apps/app/src/app/(app)/[orgId]/people/all/components/TeamMembersClient.tsx

@@ -282,6 +282,7 @@ export function TeamMembersClient({
               <SelectItem value="admin">Admin</SelectItem>
               <SelectItem value="auditor">Auditor</SelectItem>
               <SelectItem value="employee">Employee</SelectItem>
+              <SelectItem value="contractor">Contractor</SelectItem>
             </SelectContent>
           </Select>
         </div>