feat(findings): add support for evidence submissions in findings

Author: carhartlewis

apps/api/src/findings/dto/create-finding.dto.ts

@@ -12,10 +12,20 @@ export class CreateFindingDto {
   @ApiProperty({
     description: 'Task ID this finding is associated with',
     example: 'tsk_abc123',
+    required: false,
   })
   @IsString()
-  @IsNotEmpty()
-  taskId: string;
+  @IsOptional()
+  taskId?: string;
+
+  @ApiProperty({
+    description: 'Evidence submission ID this finding is associated with',
+    example: 'evs_abc123',
+    required: false,
+  })
+  @IsString()
+  @IsOptional()
+  evidenceSubmissionId?: string;
 
   @ApiProperty({
     description: 'Type of finding (SOC 2 or ISO 27001)',

apps/api/src/findings/finding-audit.service.ts

@@ -17,8 +17,10 @@ export class FindingAuditService {
    */
   async logFindingCreated(
     params: FindingAuditParams & {
-      taskId: string;
-      taskTitle: string;
+      taskId?: string;
+      taskTitle?: string;
+      evidenceSubmissionId?: string;
+      evidenceSubmissionFormType?: string;
       content: string;
       type: FindingType;
     },
@@ -37,6 +39,8 @@ export class FindingAuditService {
             findingId: params.findingId,
             taskId: params.taskId,
             taskTitle: params.taskTitle,
+            evidenceSubmissionId: params.evidenceSubmissionId,
+            evidenceSubmissionFormType: params.evidenceSubmissionFormType,
             content: params.content,
             type: params.type,
             status: FindingStatus.open,
@@ -147,8 +151,10 @@ export class FindingAuditService {
    */
   async logFindingDeleted(
     params: FindingAuditParams & {
-      taskId: string;
-      taskTitle: string;
+      taskId?: string;
+      taskTitle?: string;
+      evidenceSubmissionId?: string;
+      evidenceSubmissionFormType?: string;
       content: string;
     },
   ): Promise<void> {
@@ -166,6 +172,8 @@ export class FindingAuditService {
             findingId: params.findingId,
             taskId: params.taskId,
             taskTitle: params.taskTitle,
+            evidenceSubmissionId: params.evidenceSubmissionId,
+            evidenceSubmissionFormType: params.evidenceSubmissionFormType,
             content: params.content,
           },
         },