Merge pull request #2572 from trycompai/main

[comp] Production Deploy

Author: Marfuen

apps/api/src/findings/dto/create-finding.dto.ts

@@ -7,7 +7,7 @@ import {
   IsOptional,
   MaxLength,
 } from 'class-validator';
-import { FindingType } from '@db';
+import { FindingScope, FindingType } from '@db';
 import {
   evidenceFormTypeSchema,
   type EvidenceFormType,
@@ -43,6 +43,16 @@ export class CreateFindingDto {
   @IsOptional()
   evidenceFormType?: EvidenceFormType;
 
+  @ApiProperty({
+    description:
+      'People area scope (e.g. people directory) when not tied to a task or evidence',
+    enum: FindingScope,
+    required: false,
+  })
+  @IsEnum(FindingScope)
+  @IsOptional()
+  scope?: FindingScope;
+
   @ApiProperty({
     description: 'Type of finding (SOC 2 or ISO 27001)',
     enum: FindingType,

apps/api/src/findings/finding-audit.service.ts

@@ -21,6 +21,7 @@ export class FindingAuditService {
       taskTitle?: string;
       evidenceSubmissionId?: string;
       evidenceSubmissionFormType?: string;
+      findingScope?: string;
       content: string;
       type: FindingType;
     },
@@ -41,6 +42,7 @@ export class FindingAuditService {
             taskTitle: params.taskTitle,
             evidenceSubmissionId: params.evidenceSubmissionId,
             evidenceSubmissionFormType: params.evidenceSubmissionFormType,
+            findingScope: params.findingScope,
             content: params.content,
             type: params.type,
             status: FindingStatus.open,
@@ -155,6 +157,7 @@ export class FindingAuditService {
       taskTitle?: string;
       evidenceSubmissionId?: string;
       evidenceSubmissionFormType?: string;
+      findingScope?: string;
       content: string;
     },
   ): Promise<void> {
@@ -174,6 +177,7 @@ export class FindingAuditService {
             taskTitle: params.taskTitle,
             evidenceSubmissionId: params.evidenceSubmissionId,
             evidenceSubmissionFormType: params.evidenceSubmissionFormType,
+            findingScope: params.findingScope,
             content: params.content,
           },
         },

apps/api/src/findings/finding-notifier.service.spec.ts

@@ -10,6 +10,12 @@ jest.mock(
       soc2: 'soc2',
       iso27001: 'iso27001',
     },
+    FindingScope: {
+      people: 'people',
+      people_tasks: 'people_tasks',
+      people_devices: 'people_devices',
+      people_chart: 'people_chart',
+    },
     FindingStatus: {
       open: 'open',
       ready_for_review: 'ready_for_review',
@@ -75,8 +81,14 @@ const mockDbModule: {
     soc2: 'soc2';
     iso27001: 'iso27001';
   };
+  FindingScope: {
+    people: 'people';
+    people_tasks: 'people_tasks';
+    people_devices: 'people_devices';
+    people_chart: 'people_chart';
+  };
 } = jest.requireMock('@db');
-const { db, FindingType } = mockDbModule;
+const { db, FindingType, FindingScope } = mockDbModule;
 
 describe('FindingNotifierService', () => {
   const mockedDb = db;
@@ -194,5 +206,49 @@ describe('FindingNotifierService', () => {
         }),
       );
     });
+
+    it('builds People page URLs with tab query for scope-based findings', async () => {
+      await service.notifyFindingCreated({
+        organizationId: 'org_123',
+        findingId: 'fdg_scope',
+        findingScope: FindingScope.people_devices,
+        findingContent: 'Device area finding',
+        findingType: FindingType.soc2,
+        actorUserId: 'usr_actor',
+        actorName: 'Actor',
+      });
+
+      expect(mockedDb.task.findUnique).not.toHaveBeenCalled();
+      expect(mockedDb.evidenceSubmission.findUnique).not.toHaveBeenCalled();
+
+      expect(novuTriggerMock).toHaveBeenCalledWith(
+        expect.objectContaining({
+          payload: expect.objectContaining({
+            findingUrl: 'https://app.trycomp.ai/org_123/people?tab=people',
+          }),
+        }),
+      );
+    });
+
+    it('aligns title and URL by preferring People scope over document fields when both are set', async () => {
+      await service.notifyFindingCreated({
+        organizationId: 'org_123',
+        findingId: 'fdg_mixed',
+        findingScope: FindingScope.people,
+        evidenceSubmissionFormType: 'meeting',
+        findingContent: 'Ambiguous finding',
+        findingType: FindingType.soc2,
+        actorUserId: 'usr_actor',
+        actorName: 'Actor',
+      });
+
+      expect(novuTriggerMock).toHaveBeenCalledWith(
+        expect.objectContaining({
+          payload: expect.objectContaining({
+            findingUrl: 'https://app.trycomp.ai/org_123/people?tab=devices',
+          }),
+        }),
+      );
+    });
   });
 });