Merge pull request #2821 from trycompai/main

[comp] Production Deploy

Author: tofikwest

apps/api/.env.example

@@ -58,4 +58,5 @@ SECURITY_HUB_ROLE_ASSUMER_ARN=
 SECURITY_HUB_GOVCLOUD_ROLE_ASSUMER_ARN=
 SECURITY_HUB_GOVCLOUD_ACCESS_KEY_ID=
 SECURITY_HUB_GOVCLOUD_SECRET_ACCESS_KEY=
-SECURITY_HUB_GOVCLOUD_SESSION_TOKEN=
+# Optional: only set when using temporary GovCloud credentials. Leave unset for long-lived IAM user keys.
+# SECURITY_HUB_GOVCLOUD_SESSION_TOKEN=

apps/api/src/cloud-security/aws-partition.utils.spec.ts

@@ -57,12 +57,11 @@ describe('aws partition utils', () => {
   it('uses explicit GovCloud base credentials when configured', () => {
     process.env.SECURITY_HUB_GOVCLOUD_ACCESS_KEY_ID = 'AKIAGOV';
     process.env.SECURITY_HUB_GOVCLOUD_SECRET_ACCESS_KEY = 'secret';
-    process.env.SECURITY_HUB_GOVCLOUD_SESSION_TOKEN = 'token';
+    process.env.SECURITY_HUB_GOVCLOUD_SESSION_TOKEN = 'placeholder';
 
     expect(getAwsBaseCredentials('aws-us-gov')).toEqual({
       accessKeyId: 'AKIAGOV',
       secretAccessKey: 'secret',
-      sessionToken: 'token',
     });
     expect(getAwsBaseCredentials('aws')).toBeUndefined();
 

apps/api/src/cloud-security/aws-partition.utils.ts

@@ -41,7 +41,6 @@ export function getAwsBaseCredentials(
   return {
     accessKeyId,
     secretAccessKey,
-    sessionToken: process.env.SECURITY_HUB_GOVCLOUD_SESSION_TOKEN,
   };
 }
 

apps/api/src/evidence-forms/evidence-forms.service.ts

@@ -196,16 +196,16 @@ export class EvidenceFormsService {
       );
     }
 
-    const base64Pattern = /^[A-Za-z0-9+/]+={0,2}$/;
-    if (!base64Pattern.test(normalized)) {
+    const fileBuffer = Buffer.from(normalized, 'base64');
+
+    if (fileBuffer.toString('base64') !== normalized) {
       throw new BadRequestException(
         'Invalid file data. Expected base64 string.',
       );
     }
 
-    const fileBuffer = Buffer.from(normalized, 'base64');
     if (!fileBuffer.length) {
-      throw new BadRequestException('File cannot be empty');
+      throw new BadRequestException('File cannot be empty.');
     }
 
     return fileBuffer;