Skip to content

[comp] Production Deploy#2608

Merged
Marfuen merged 2 commits intoreleasefrom
main
Apr 20, 2026
Merged

[comp] Production Deploy#2608
Marfuen merged 2 commits intoreleasefrom
main

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot commented Apr 20, 2026

This is an automated pull request to release the candidate branch into production, which will trigger a deployment.
It was created by the [Production PR] action.


Summary by cubic

Allow creating a new policy version when the editor content is empty or when only a PDF exists, instead of blocking with a Bad Request. Adds tests for empty-content and PDF-only paths, plus a NotFound case.

  • Bug Fixes
    • Default version content to an empty array and reuse/copy existing pdfUrl via AttachmentsService.copyPolicyVersionPdf.
    • Expanded createVersion tests to cover empty content with/without PDF and missing policy; updated DB mocks accordingly.

Written for commit a78d96b. Summary will update on new commits.

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
comp-framework-editor Ready Ready Preview, Comment Apr 20, 2026 5:44pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
app (staging) Skipped Skipped Apr 20, 2026 5:44pm
portal (staging) Skipped Skipped Apr 20, 2026 5:44pm

Request Review

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Requires human review: This PR modifies core business logic by changing validation rules for policy version creation, which requires human review to ensure it doesn't negatively impact downstream systems.

@Marfuen Marfuen merged commit 8193f61 into release Apr 20, 2026
13 checks passed
@claudfuen
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 3.25.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants