Conversation
…tive org The GET /v1/frameworks/available endpoint was changed on April 17 to read @organizationId() from the request. That decorator throws when the user has no active organization, producing HTTP 500 for every fresh signup on the first onboarding step — even though @SkipOrgCheck() is specifically meant to allow this case. - Add @OrganizationIdOptional() for @SkipOrgCheck()-decorated endpoints - Harden @organizationId() to throw InternalServerErrorException with a message pointing to the optional variant, so future misuse is visible in monitoring instead of a generic 500 - Swap findAvailable to use @OrganizationIdOptional() - Add regression tests covering both no-org and with-org cases - Surface API errors in FrameworkSelection.tsx so the next server-side failure doesn't produce a silent blank onboarding screen Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…ilable-500 fix(api,app): unblock onboarding frameworks list for users without active org
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
|
🎉 This PR is included in version 3.27.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated pull request to release the candidate branch into production, which will trigger a deployment.
It was created by the [Production PR] action.
Summary by cubic
Fixes onboarding 500s by allowing
/v1/frameworks/availableto work without an active org and by surfacing API errors in the framework selection UI. Adds@OrganizationIdOptional()and tightens@OrganizationId()to avoid future misuse on@SkipOrgCheck()routes.@OrganizationIdOptional()for endpoints decorated with@SkipOrgCheck().findAvailableto use@OrganizationIdOptional()and return data when no org is active.@OrganizationId()throwInternalServerErrorExceptionwith guidance to use the optional variant.FrameworkSelection.tsxinstead of a blank state.Written for commit 4466792. Summary will update on new commits.