oauth login, /me fix

Author: robotizeit

src/cli/credentials.rs

@@ -586,7 +586,6 @@ pub fn fetch_user_email(auth_url: &str, access_token: &str) -> Result<Option<Str
     }
 
     let data: serde_json::Value = resp.json().unwrap_or(serde_json::Value::Null);
-    // /oauth_server/api/me returns {"user": {"email": ...}}
     let email = data.get("email")
         .or_else(|| data.get("user").and_then(|u| u.get("email")))
         .and_then(|v| v.as_str())
@@ -1171,7 +1170,11 @@ mod tests {
             domain: None,
         };
 
+        // Isolate from the real ~/.config/stacker/config.yml which may provide a fallback URL.
+        let tmp = tempfile::tempdir().unwrap();
+        std::env::set_var("XDG_CONFIG_HOME", tmp.path());
         let err = login(&manager, &oauth, &request).unwrap_err();
+        std::env::remove_var("XDG_CONFIG_HOME");
         assert!(format!("{err}").contains("Missing auth URL"));
     }
 
@@ -1188,7 +1191,11 @@ mod tests {
             domain: None,
         };
 
+        // Isolate from the real ~/.config/stacker/config.yml which may provide a fallback URL.
+        let tmp = tempfile::tempdir().unwrap();
+        std::env::set_var("XDG_CONFIG_HOME", tmp.path());
         let err = login(&manager, &oauth, &request).unwrap_err();
+        std::env::remove_var("XDG_CONFIG_HOME");
         assert!(format!("{err}").contains("Missing Stacker API URL"));
     }
 

src/console/commands/cli/login.rs

@@ -27,13 +27,12 @@ impl LoginCommand {
         provider: Option<String>,
         user: Option<String>,
     ) -> Self {
-        let cfg = UserConfig::load();
         Self {
             org,
             domain,
             auth_url,
             server_url,
-            browser: browser || cfg.browser_default(),
+            browser,  // raw flag only; browser_default() is applied in call()
             provider,
             user,
         }
@@ -118,7 +117,11 @@ impl LoginCommand {
 impl CallableTrait for LoginCommand {
     fn call(&self) -> Result<(), Box<dyn std::error::Error>> {
         // --user/-u always means email/password; skip prompt and browser.
-        let use_browser = self.user.is_none() && (self.browser || io::stdin().is_terminal());
+        // --browser flag forces browser; on a tty, browser_default() from config applies.
+        // Piped stdin always falls back to email/password regardless of config.
+        let use_browser = self.user.is_none() && (
+            self.browser || (io::stdin().is_terminal() && UserConfig::load().browser_default())
+        );
 
         if use_browser {
             // Resolve provider — may show an interactive menu.

src/console/commands/cli/secrets.rs

@@ -1814,11 +1814,11 @@ mod tests {
     }
 
     #[test]
-    fn test_remote_server_target_requires_server_id() {
+    fn test_remote_server_target_allows_missing_server_id() {
+        // server_id may be omitted at parse time; it is resolved from the
+        // lock file at execution time via server_id_from_lock().
         let target = RemoteSecretTarget::new(RemoteSecretScope::Server, None, None, None);
-
-        let error = target.validate().unwrap_err().to_string();
-        assert!(error.contains("--server-id"));
+        assert!(target.validate().is_ok());
     }
 
     #[test]