use no-op when cancelling gift card subscriptions

since these subscriptions are not auto-renewing, a no-op makes their
behaviour consistent with the other two providers by cancelling
subscription at the end of current billing cycle

Author: ashutoshgngwr

src/integrationTest/java/com/trynoice/api/subscription/SubscriptionControllerTest.java

@@ -34,7 +34,6 @@
 
 import javax.persistence.EntityManager;
 import javax.transaction.Transactional;
-import java.time.OffsetDateTime;
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.HashMap;
@@ -410,7 +409,6 @@ void cancelSubscription(
                         .cancelSubscription(subscription.getProvidedId());
                     break;
                 case GIFT_CARD:
-                    assertTrue(subscription.getEndAt().isBefore(OffsetDateTime.now()));
                     break;
                 default:
                     throw new RuntimeException("unknown provider");

src/main/java/com/trynoice/api/subscription/SubscriptionService.java

@@ -332,7 +332,7 @@ public void cancelSubscription(@NonNull Long customerId, @NonNull Long subscript
 
                 break;
             case GIFT_CARD:
-                subscription.setEndAt(OffsetDateTime.now());
+                // no-op as gift card subscriptions are not auto-renewing.
                 break;
             default:
                 throw new IllegalStateException("unsupported provider used in subscription plan");

src/test/java/com/trynoice/api/subscription/SubscriptionServiceTest.java

@@ -52,7 +52,6 @@
 import static org.junit.jupiter.api.Assertions.assertNotNull;
 import static org.junit.jupiter.api.Assertions.assertNull;
 import static org.junit.jupiter.api.Assertions.assertThrows;
-import static org.junit.jupiter.api.Assertions.assertTrue;
 import static org.junit.jupiter.params.provider.Arguments.arguments;
 import static org.mockito.ArgumentMatchers.any;
 import static org.mockito.ArgumentMatchers.eq;
@@ -325,7 +324,6 @@ <T extends Throwable> void cancelSubscription(
                         .cancelSubscription(subscription.getProvidedId());
                     break;
                 case GIFT_CARD:
-                    assertTrue(subscription.getEndAt().isBefore(OffsetDateTime.now()));
                     break;
                 default:
                     throw new RuntimeException("unknown provider");