Skip to content

Commit 4a19b81

Browse files
committed
fix 'isRedeemed' field naming error in GiftCardResponse
1 parent b79f1b7 commit 4a19b81

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

src/main/java/com/trynoice/api/subscription/payload/GiftCardResponse.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,8 @@ public class GiftCardResponse {
2525
private int hourCredits;
2626

2727
@Schema(required = true, description = "whether the gift card has been redeemed.")
28-
private boolean isRedeemed;
28+
@NonNull
29+
private Boolean isRedeemed;
2930

3031
@Schema(type = "integer", format = "int64", description = "optional epoch millis when the gift card expires.")
3132
private OffsetDateTime expiresAt;

src/test/java/com/trynoice/api/subscription/SubscriptionServiceTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -357,7 +357,7 @@ void getGiftCard_withValidCode() {
357357
val response = assertDoesNotThrow(() -> service.getGiftCard(2L, code));
358358
assertEquals(card.getCode(), response.getCode());
359359
assertEquals(card.getHourCredits(), response.getHourCredits());
360-
assertEquals(card.isRedeemed(), response.isRedeemed());
360+
assertEquals(card.isRedeemed(), response.getIsRedeemed());
361361
assertEquals(card.getExpiresAt(), response.getExpiresAt());
362362
}
363363

0 commit comments

Comments
 (0)