Fix padding bug + add space for new chats too#298
Merged
Conversation
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 147e2e5 in 52 seconds
More details
- Looked at
25lines of code in1files - Skipped
0files when reviewing. - Skipped posting
5drafted comments based on config settings.
1. gui/src/pages/gui.tsx:235
- Draft comment:
Ensure removal of isNewSession logic for newPadding is intentional. This always applies padding, which aligns with the new chat spacing fix. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
2. gui/src/pages/gui.tsx:370
- Draft comment:
Updated adjustPadding to compute height internally (removing parameter). Verify that all onHeightChange callers no longer require a height argument. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
3. gui/src/pages/gui.tsx:235
- Draft comment:
Removed the isNewSession condition when calculating padding. Confirm that always adding${height + 20}pxfor padding is the intended behavior for new sessions. - Reason this comment was not posted:
Comment looked like it was already resolved.
4. gui/src/pages/gui.tsx:376
- Draft comment:
The adjustPadding callback now fetches the height from inputContainerRef and removes its parameter. Confirm that the ContinueInputBox's onHeightChange callback no longer needs to pass a height. - Reason this comment was not posted:
Comment looked like it was already resolved.
5. gui/src/pages/gui.tsx:186
- Draft comment:
It appears that 'OFFSET_HERUISTIC' might be a typographical mistake. Perhaps you intended to use 'OFFSET_HEURISTIC'? - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
Workflow ID: wflow_hyvSRCXKjKcMIKDS
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
|
Shieeee ok |
|
Tysm, we r taking a look |
|
@Himanshu-Singh-Chauhan @tokaa1
i think this messes stuff up on PearAI Chat when we enlarge text (cmd+"+") we'll need to revert or fix! |
tokaa1
added a commit
to tokaa1/pearai-submodule
that referenced
this pull request
Apr 21, 2025
This reverts commit 79e54b1.
Author
nang-dev
pushed a commit
that referenced
this pull request
Apr 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Sometimes the padding of chat content would be wrong and look like this (input container is on top of the text):


Also during first message of new chats, output would be covered by cancel button.
Ts pmo 😜👺👺😿😿😿
This fixes both issues, now they always look normal!
Couldn't get a screenshot of second fix (it's just how it normally looks)
Important
Fixes chat padding and cancel button coverage issues in
GUI()by adjusting padding logic ingui.tsx.GUI()by removing conditional padding logic for new sessions.adjustPaddingingui.tsxto calculate padding based oninputContainerRefheight.useEffectforResizeObserverto consistently apply padding adjustments.This description was created by
for 147e2e5. It will automatically update as commits are pushed.