Translate the pb core

Author: trypsynth

Cargo.lock

@@ -7,6 +7,9 @@ license.workspace = true
 repository.workspace = true
 description = "Core document parsing and reading logic for Paperback"
 
+[package.metadata.patois]
+translatable = true
+
 [lib]
 name = "paperback_core"
 path = "src/lib.rs"
@@ -22,6 +25,7 @@ encoding_rs = "0.8.35"
 icu_properties = { version = "2.2.0", features = ["unicode_bidi"] }
 libchm = "0.2.0"
 office-crypto = "0.2.0"
+patois = { git = "https://github.com/trypsynth/patois.git" }
 pdfium = "0.10.4"
 percent-encoding = "2.3.2"
 pulldown-cmark = { version = "0.13.4", default-features = false, features = ["html"] }

crates/paperback-core/Cargo.toml

@@ -26,10 +26,10 @@ pub fn set_pdfium_library_path(path: String) {
 	pdfium::set_library_location(&path);
 }
 
-/// Minimal translation stub for library-internal strings (e.g. document content labels).
-/// The GUI binary sets up the real wxWidgets translation system independently; strings
-/// returned by this function are English only and are intended for non-GUI consumers
-/// (CLI, mobile bindings) or for embedding into document content.
+/// Translates library-internal strings (e.g. document content labels, parser error messages).
+/// Delegates to `patois`'s process-global registry: when the GUI binary calls `patois::init`
+/// at startup, these strings come back translated automatically. Non-GUI consumers (CLI,
+/// mobile bindings) that never call `patois::init` get the English source string back unchanged.
 pub(crate) fn t(s: &str) -> String {
-	s.to_owned()
+	patois::t(s)
 }

crates/paperback-core/src/lib.rs

@@ -9,6 +9,7 @@ use anyhow::Result;
 
 use crate::{
 	document::{Document, DocumentBuffer, Marker, MarkerType, ParserContext, ParserFlags},
+	t,
 	types::{HeadingInfo, ImageInfo, LinkInfo, ListInfo, ListItemInfo, SeparatorInfo, TableInfo},
 };
 
@@ -126,15 +127,17 @@ pub fn parse_document(context: &ParserContext) -> Result<Document> {
 	let path = Path::new(&context.file_path);
 	let extension = context.forced_extension.as_ref().map_or_else(
 		|| {
-			path.extension()
-				.and_then(|e| e.to_str())
-				.ok_or_else(|| anyhow::anyhow!("No file extension found for: {}", context.file_path))
+			path.extension().and_then(|e| e.to_str()).ok_or_else(|| {
+				// TRANSLATORS: Error shown when a file has no extension to determine its format; {} is the file path
+				anyhow::anyhow!(t("No file extension found for: {}").replace("{}", &context.file_path))
+			})
 		},
 		|ext| Ok(ext.as_str()),
 	)?;
 	let parsers = ParserRegistry::global().get_parsers_for_extension(extension);
 	if parsers.is_empty() {
-		return Err(anyhow::anyhow!("No parser found for extension: .{extension}"));
+		// TRANSLATORS: Error shown when no parser supports a file's extension; {} is the extension (without the leading dot)
+		return Err(anyhow::anyhow!(t("No parser found for extension: .{}").replace("{}", extension)));
 	}
 	let mut last_error = None;
 	for parser in parsers {
@@ -151,7 +154,10 @@ pub fn parse_document(context: &ParserContext) -> Result<Document> {
 			}
 		}
 	}
-	Err(last_error.unwrap_or_else(|| anyhow::anyhow!("All parsers failed for extension: .{extension}")))
+	Err(last_error.unwrap_or_else(|| {
+		// TRANSLATORS: Error shown when every parser for a file's extension failed; {} is the extension (without the leading dot)
+		anyhow::anyhow!(t("All parsers failed for extension: .{}").replace("{}", extension))
+	}))
 }
 
 #[must_use]

crates/paperback-core/src/parser.rs

@@ -16,6 +16,7 @@ use crate::{
 		util::{path::extract_title_from_path, toc::build_toc_from_headings},
 		xml_to_text::XmlToText,
 	},
+	t,
 	util::zip::read_zip_entry_by_name_with_password,
 };
 
@@ -101,7 +102,8 @@ impl Parser for DaisyParser {
 							buffer.add_marker(Marker::new(MarkerType::PageBreak, pb.offset).with_text(pb.text.clone()));
 						}
 					} else {
-						anyhow::bail!("Failed to convert DTBook XML to text");
+						// TRANSLATORS: Error shown when a DAISY book's DTBook XML fails to convert to plain text
+						anyhow::bail!(t("Failed to convert DTBook XML to text"));
 					}
 					let mut toc_items = None;
 					let ncx_path = archive
@@ -171,7 +173,8 @@ impl Parser for DaisyParser {
 					});
 				}
 			}
-			anyhow::bail!("ZIP archive does not appear to be a valid DAISY 3 or DAISY 2.02 book");
+			// TRANSLATORS: Error shown when a ZIP file is not a recognizable DAISY 3 or DAISY 2.02 book
+			anyhow::bail!(t("ZIP archive does not appear to be a valid DAISY 3 or DAISY 2.02 book"));
 		}
 		let file_content = std::fs::read_to_string(path)?;
 		let (manifest_xml, metadata) = parse_opf_metadata_and_manifest(&file_content)?;
@@ -219,7 +222,8 @@ impl Parser for DaisyParser {
 				});
 			}
 		}
-		anyhow::bail!("Invalid DAISY .opf file or could not find DTBook XML in manifest");
+		// TRANSLATORS: Error shown when a DAISY .opf file is invalid or its DTBook XML can't be located
+		anyhow::bail!(t("Invalid DAISY .opf file or could not find DTBook XML in manifest"));
 	}
 }
 

crates/paperback-core/src/parser/daisy.rs

@@ -18,6 +18,7 @@ use crate::{
 		util::path::extract_title_from_path,
 		xml_to_text::XmlToText,
 	},
+	t,
 	types::{HeadingInfo, LinkInfo, ListInfo, ListItemInfo, SeparatorInfo, TableInfo},
 	util::{
 		text::{collapse_whitespace, trim_string, url_decode},
@@ -133,16 +134,20 @@ impl Parser for EpubParser {
 		let package_node = opf_doc
 			.descendants()
 			.find(|n| n.node_type() == NodeType::Element && n.tag_name().name() == "package")
-			.ok_or_else(|| anyhow::anyhow!("OPF package element missing"))?;
+			// TRANSLATORS: Error shown when an EPUB's OPF document has no <package> element
+			.ok_or_else(|| anyhow::anyhow!(t("OPF package element missing")))?;
 		let (manifest, spine, nav_path, ncx_path, metadata) = parse_package(package_node, &opf_dir);
 		let mut conversion = convert_spine_items(&mut archive, &manifest, &spine, context.render_tables_inline);
 		if conversion.sections.is_empty() {
 			let reason = if conversion.conversion_errors.is_empty() {
-				String::from("no readable spine items")
+				// TRANSLATORS: Reason given when an EPUB has no spine items that could be read
+				t("no readable spine items")
 			} else {
-				format!("failed to convert spine items: {}", conversion.conversion_errors.join(", "))
+				// TRANSLATORS: Reason given when EPUB spine items failed to convert; {} is a comma-separated list of underlying errors
+				t("failed to convert spine items: {}").replace("{}", &conversion.conversion_errors.join(", "))
 			};
-			anyhow::bail!("EPUB has no readable content ({reason})");
+			// TRANSLATORS: Error shown when an EPUB has no readable content; {} is the specific reason (see the two messages above)
+			anyhow::bail!(t("EPUB has no readable content ({})").replace("{}", &reason));
 		}
 		let title = metadata
 			.title
@@ -275,7 +280,8 @@ fn find_container_path<R: Read + Seek>(archive: &mut ZipArchive<R>) -> Result<St
 			return Ok(path.to_string());
 		}
 	}
-	anyhow::bail!("rootfile not found in container.xml")
+	// TRANSLATORS: Error shown when an EPUB's container.xml is missing its rootfile reference
+	anyhow::bail!(t("rootfile not found in container.xml"))
 }
 
 struct PackageMetadata {
@@ -386,7 +392,8 @@ fn convert_section(content: &str, render_tables_inline: bool) -> Result<SectionC
 			id_positions: html_converter.get_id_positions().clone(),
 		});
 	}
-	anyhow::bail!("unsupported content")
+	// TRANSLATORS: Error shown when an EPUB spine item's content type cannot be converted
+	anyhow::bail!(t("unsupported content"))
 }
 
 fn resolve_href(current_path: &str, target: &str) -> String {

crates/paperback-core/src/parser/epub.rs

@@ -10,6 +10,7 @@ use crate::{
 		util::xml::{collect_element_text, find_child_element},
 		xml_to_text::XmlToText,
 	},
+	t,
 };
 
 type Metadata = (String, String);
@@ -42,7 +43,8 @@ impl Parser for Fb2Parser {
 		});
 		let mut converter = XmlToText::with_render_tables_inline(context.render_tables_inline);
 		if !converter.convert(&xml_content) {
-			anyhow::bail!("Failed to convert FB2 XML to text");
+			// TRANSLATORS: Error shown when an FB2 (FictionBook) file's XML fails to convert to plain text
+			anyhow::bail!(t("Failed to convert FB2 XML to text"));
 		}
 		let mut buffer = DocumentBuffer::new();
 		buffer.append(&converter.get_text());

crates/paperback-core/src/parser/fb2.rs

@@ -9,6 +9,7 @@ use crate::{
 		html_to_text::{HtmlSourceMode, HtmlToText},
 		util::{path::extract_title_from_path, toc::build_toc_from_headings},
 	},
+	t,
 	util::encoding::convert_to_utf8,
 };
 
@@ -31,12 +32,14 @@ impl Parser for HtmlParser {
 		let bytes = fs::read(&context.file_path)
 			.with_context(|| format!("Failed to open HTML file '{}'", context.file_path))?;
 		if bytes.is_empty() {
-			anyhow::bail!("HTML file is empty: {}", context.file_path);
+			// TRANSLATORS: Error shown when an HTML file has no content; {} is the file path
+			anyhow::bail!(t("HTML file is empty: {}").replace("{}", &context.file_path));
 		}
 		let html_content = convert_to_utf8(&bytes);
 		let mut converter = HtmlToText::with_render_tables_inline(context.render_tables_inline);
 		if !converter.convert(&html_content, HtmlSourceMode::NativeHtml) {
-			anyhow::bail!("Failed to convert HTML to text: {}", context.file_path);
+			// TRANSLATORS: Error shown when an HTML file fails to convert to plain text; {} is the file path
+			anyhow::bail!(t("Failed to convert HTML to text: {}").replace("{}", &context.file_path));
 		}
 		let extracted_title = converter.get_title();
 		let title = if extracted_title.is_empty() {

crates/paperback-core/src/parser/html.rs

@@ -10,6 +10,7 @@ use crate::{
 		html_to_text::{HtmlSourceMode, HtmlToText},
 		util::{path::extract_title_from_path, toc::build_toc_from_headings},
 	},
+	t,
 	util::encoding::convert_to_utf8,
 };
 
@@ -125,7 +126,8 @@ impl Parser for MarkdownParser {
 		let html_content = markdown_to_html(&markdown_content);
 		let mut converter = HtmlToText::with_render_tables_inline(context.render_tables_inline);
 		if !converter.convert(&html_content, HtmlSourceMode::Markdown) {
-			anyhow::bail!("Failed to convert Markdown to text: {}", context.file_path);
+			// TRANSLATORS: Error shown when a Markdown file fails to convert to plain text; {} is the file path
+			anyhow::bail!(t("Failed to convert Markdown to text: {}").replace("{}", &context.file_path));
 		}
 		let title = extract_title_from_path(&context.file_path);
 		let text = converter.get_text();