Commit 0bafb2c
fix: Add proper CMake detection for uuid library instead of blind linking
Problem: CMakeLists.txt was unconditionally linking uuid library without
verifying it exists. Build fails on systems without libuuid installed.
Solution:
- Use find_library(UUID_LIBRARY NAMES uuid libuuid) to detect uuid
- Only link uuid if found (set UUID_FOUND conditional)
- Warn users if uuid not available (degraded Paimon/Iceberg functionality)
This follows CMake best practices for optional dependencies and prevents
build failures when uuid is not installed.
Addresses PR #5 review comment: "CMakeLists.txt blindly links libuuid without detection"
Testing:
- ✅ Build succeeds with uuid detected and linked
- ✅ Paimon writer works (84K rows/sec)
- ✅ All targets built successfully (tpch_benchmark, examples, etc)
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>1 parent 5b7fe91 commit 0bafb2c
1 file changed
Lines changed: 16 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
100 | 100 | | |
101 | 101 | | |
102 | 102 | | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
103 | 114 | | |
104 | 115 | | |
105 | 116 | | |
| |||
349 | 360 | | |
350 | 361 | | |
351 | 362 | | |
352 | | - | |
353 | 363 | | |
354 | 364 | | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
355 | 370 | | |
356 | 371 | | |
357 | 372 | | |
| |||
0 commit comments