Skip to content

Commit 1b44b1f

Browse files
committed
feat: drop log format 'text'
1 parent 4d1cb9e commit 1b44b1f

4 files changed

Lines changed: 13 additions & 16 deletions

File tree

README.md

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -31,17 +31,17 @@ Start the server on `localhost:8080` by default.
3131
```
3232
For further configuration, see the command-line options below.
3333

34-
| Flag | Description | Default |
35-
|----------------------|-------------------------------------------------|-------------|
36-
| `-H`, `--host` | Host to bind the server to | `localhost` |
37-
| `-p`, `--port` | Port to run the server on | `8080` |
38-
| `-a`, `--auth` | Enable bearer token authentication | `false` |
39-
| `-t`, `--token` | Bearer token used for authentication | |
40-
| `-m`, `--metrics` | Enable Prometheus metrics endpoint | `false` |
41-
| `-r`, `--redoc` | Enable ReDoc API documentation | `false` |
42-
| `-f`, `--log-format` | Set log format: `text`, `structured`, `json` | `text` |
43-
| `-l`, `--log-level` | Set log level: `debug`, `info`, `warn`, `error` | `info` |
44-
| `-h`, `--help` | Show help for the server command | |
34+
| Flag | Description | Default |
35+
|----------------------|-------------------------------------------------|--------------|
36+
| `-H`, `--host` | Host to bind the server to | `localhost` |
37+
| `-p`, `--port` | Port to run the server on | `8080` |
38+
| `-a`, `--auth` | Enable bearer token authentication | `false` |
39+
| `-t`, `--token` | Bearer token used for authentication | |
40+
| `-m`, `--metrics` | Enable Prometheus metrics endpoint | `false` |
41+
| `-r`, `--redoc` | Enable ReDoc API documentation | `false` |
42+
| `-f`, `--log-format` | Set log format: `structured`, `json` | `structured` |
43+
| `-l`, `--log-level` | Set log level: `debug`, `info`, `warn`, `error` | `info` |
44+
| `-h`, `--help` | Show help for the server command | |
4545

4646
Additional a systemd service file and environment file are provided in the
4747
[contrib directory](https://github.com/tschaefer/rpinfo/tree/main/contrib) for automatic startup on boot and management of the

cmd/server.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ func init() {
2323
serverCmd.Flags().StringP("token", "t", "", "Bearer Token for authentication")
2424
serverCmd.Flags().BoolP("metrics", "m", false, "Enable Prometheus metrics")
2525
serverCmd.Flags().BoolP("redoc", "r", false, "Enable ReDoc API documentation")
26-
serverCmd.Flags().StringP("log-format", "f", "text", "Log format (text, structured, json)")
26+
serverCmd.Flags().StringP("log-format", "f", "structured", "Log format (structured, json)")
2727
serverCmd.Flags().StringP("log-level", "l", "info", "Log level (debug, info, warn, error)")
2828

2929
rootCmd.AddCommand(serverCmd)

server/log/log.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,6 @@ func Logger(level, format string) error {
3636
logger = slog.New(slog.NewTextHandler(os.Stdout, opts))
3737
case "json":
3838
logger = slog.New(slog.NewJSONHandler(os.Stdout, opts))
39-
case "text":
40-
// Use default logger, print info level only.
41-
return nil
4239
default:
4340
return fmt.Errorf("unknown log format: %s", format)
4441
}

server/log/log_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ func Test_LoggerReturnsErrorIfFormatIsUnknown(t *testing.T) {
3030

3131
func Test_LoggerReturnsNoErrorIfLevelAndFormatAreKnown(t *testing.T) {
3232
levels := []string{"debug", "info", "warn", "error"}
33-
formats := []string{"structured", "json", "text"}
33+
formats := []string{"structured", "json"}
3434

3535
for _, level := range levels {
3636
for _, format := range formats {

0 commit comments

Comments
 (0)