fix(review): address code review findings on PR #44

- Validate replayed score's archetype against registry in both server
  (400 for unknown archetype) and CLI (exit with clear error). Prevents
  silent job failures when score.json references a removed archetype.
- Remove dead replayScorePath field from RunLog (declared but never set).
- Fix web UI direction counter to use byte length (TextEncoder) matching
  the server's Buffer.byteLength check. Prevents CJK text from hitting
  the server 10KB limit while the UI shows it under the character limit.

Author: Talha Jubair Siam

src/index.ts

@@ -4,6 +4,7 @@ import * as fs from "node:fs";
 import { parseArgs } from "./cli/args.js";
 import { showUsageReport } from "./cli/usage-report.js";
 import { validateEnv } from "./cli/validate-env.js";
+import { getArchetype } from "./config/archetype-registry.js";
 import { createCliCallbacks, runPipeline } from "./pipeline/orchestrator.js";
 import { createProviders, createVerificationModel } from "./providers/factory.js";
 import { DirectorScore } from "./schema/director-score.js";
@@ -53,6 +54,8 @@ async function main(): Promise<void> {
     try {
       const raw = fs.readFileSync(opts.score, "utf-8");
       replayScore = DirectorScore.parse(JSON.parse(raw));
+      // Validate archetype exists in the registry
+      getArchetype(replayScore.archetype);
     } catch (err) {
       if ((err as NodeJS.ErrnoException).code === "ENOENT") {
         console.error(`Score file not found: ${opts.score}`);

src/pipeline/orchestrator.ts

@@ -122,7 +122,6 @@ interface RunLog {
   musicResolution?: { provider: string; prompt?: string; metadata?: Record<string, unknown>; fallback: boolean };
   direction?: string;
   replay?: boolean;
-  replayScorePath?: string;
 }
 
 // ──────────────────────────────────────────────────────────────────────────────

src/server.ts

@@ -248,6 +248,14 @@ app.post<{ Body: CreateJobBody }>("/api/v1/jobs", async (request, reply) => {
     if (!result.success) {
       return reply.status(400).send({ error: `Invalid DirectorScore: ${result.error.message}` });
     }
+    // Validate archetype exists in the registry (Zod accepts any string, but getArchetype throws for unknown names)
+    try {
+      getArchetype((result.data as { archetype: string }).archetype);
+    } catch {
+      return reply.status(400).send({
+        error: `Score references unknown archetype: ${(result.data as { archetype: string }).archetype}`,
+      });
+    }
     validatedScore = result.data;
   }
 

web/src/pages/HomePage.tsx

@@ -424,12 +424,14 @@ export function HomePage() {
                       className="w-full rounded-lg border border-border bg-transparent px-3 py-2 text-sm placeholder:text-text-faint focus:outline-none focus:ring-1 focus:ring-primary/40 resize-y min-h-[60px]"
                       placeholder="Describe your creative vision: visual style, mood, script notes, scene ideas, music preference..."
                       value={directionText}
-                      onChange={(e) => setDirectionText(e.target.value)}
-                      maxLength={10000}
+                      onChange={(e) => {
+                        const bytes = new TextEncoder().encode(e.target.value).length;
+                        if (bytes <= 10240) setDirectionText(e.target.value);
+                      }}
                       rows={3}
                     />
                     <p className="mt-1 text-right text-[10px] text-muted-foreground">
-                      {directionText.length.toLocaleString()} / 10,000
+                      {new TextEncoder().encode(directionText).length.toLocaleString()} / 10,240 bytes
                     </p>
                   </div>