Skip to content

Remove hullend struct#2384

Merged
jeromekelleher merged 5 commits into
tskit-dev:mainfrom
jeromekelleher:remove_hullend_struct
Jul 24, 2025
Merged

Remove hullend struct#2384
jeromekelleher merged 5 commits into
tskit-dev:mainfrom
jeromekelleher:remove_hullend_struct

Conversation

@jeromekelleher

Copy link
Copy Markdown
Member

Initial work on #2383

As I work through it, I wonder if we can save some time on AVL tree maintenance by storing pointers to the left and right AVL tree nodes in the hull. It's not much space and would simplify things quite a bit.

Should probably work it out on the Python implementation first though.

Also remove the specific logic for moving the RHS of a hull. Seems
better to simplify the code first and optimise there later if needed.
@codecov

codecov Bot commented Jul 24, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 95.41284% with 5 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@ee2b6c0). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
lib/msprime.c 95.41% 2 Missing and 3 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2384   +/-   ##
=======================================
  Coverage        ?   91.22%           
=======================================
  Files           ?       20           
  Lines           ?    11834           
  Branches        ?     2294           
=======================================
  Hits            ?    10795           
  Misses          ?      570           
  Partials        ?      469           
Flag Coverage Δ
C 91.22% <95.41%> (?)
python 98.68% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jeromekelleher

Copy link
Copy Markdown
Member Author

Closes #2383

@jeromekelleher

Copy link
Copy Markdown
Member Author

This also embeds the AVL nodes needed by the hull in the left and right AVL trees, which significantly reduces the need for searching around and simplifies the code.

@jeromekelleher jeromekelleher merged commit 26bcbf8 into tskit-dev:main Jul 24, 2025
14 checks passed
@jeromekelleher jeromekelleher deleted the remove_hullend_struct branch July 24, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant