Skip to content

smck_Verification#2398

Merged
jeromekelleher merged 1 commit into
tskit-dev:mainfrom
hossam26644:verification
Sep 2, 2025
Merged

smck_Verification#2398
jeromekelleher merged 1 commit into
tskit-dev:mainfrom
hossam26644:verification

Conversation

@hossam26644

Copy link
Copy Markdown
Contributor

@jeromekelleher check these tests (including a gc)
solves #2377 and #2378

@hossam26644

Copy link
Copy Markdown
Contributor Author

now should also solve #2379

@hossam26644

Copy link
Copy Markdown
Contributor Author
image that's the ooa test working now. This is ready for review

@hossam26644 hossam26644 marked this pull request as ready for review September 2, 2025 11:16
@codecov

codecov Bot commented Sep 2, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.23%. Comparing base (3ab7369) to head (413d39e).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2398   +/-   ##
=======================================
  Coverage   91.23%   91.23%           
=======================================
  Files          20       20           
  Lines       11828    11828           
  Branches     2295     2295           
=======================================
  Hits        10791    10791           
  Misses        568      568           
  Partials      469      469           
Flag Coverage Δ
C 91.23% <ø> (ø)
python 98.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jeromekelleher

Copy link
Copy Markdown
Member

Can you rebase and squash please? There's a whole bunch of commits in here that aren't relevant

@jeromekelleher jeromekelleher merged commit 6c5978a into tskit-dev:main Sep 2, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants