Skip to content

Reqs in pyproject#2413

Merged
benjeffery merged 1 commit into
tskit-dev:mainfrom
benjeffery:pyproject
Sep 5, 2025
Merged

Reqs in pyproject#2413
benjeffery merged 1 commit into
tskit-dev:mainfrom
benjeffery:pyproject

Conversation

@benjeffery
Copy link
Copy Markdown
Member

@benjeffery benjeffery commented Sep 4, 2025

I've been thinking about tidying up the requirements files for some time. The modern way it to move them into pyproject.toml. Do people like this?

@molpopgen
Copy link
Copy Markdown
Member

Yes, but there are some caveats. Some tools that work with pyproject may not respect pinning build dependencies. Example

But overall, switching to pyproject for my projects has been a big win, especially when using uv to manage everything.

@jeromekelleher
Copy link
Copy Markdown
Member

I think it's a win too. How does this gel with doing things with conda though?

@molpopgen
Copy link
Copy Markdown
Member

conda makes things harder, of course. AFAIK, it doesn't understand pyproject.toml. The language-agnosticism of conda seems to imply that its requirements files are a separate thing.

@benjeffery
Copy link
Copy Markdown
Member Author

Yeah, we'd need to retain a conda text reqs for gsl on windows/mac, or hardcode it in CI.

@jeromekelleher
Copy link
Copy Markdown
Member

That's not so bad.

@benjeffery benjeffery force-pushed the pyproject branch 5 times, most recently from 0307205 to 910625b Compare September 5, 2025 10:34
@jeromekelleher
Copy link
Copy Markdown
Member

I'm going to mute this one @benjeffery - ping me if you want input

@benjeffery benjeffery force-pushed the pyproject branch 2 times, most recently from 8336cf0 to b2b5340 Compare September 5, 2025 10:43
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.23%. Comparing base (7a0ff9d) to head (87b26a6).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2413   +/-   ##
=======================================
  Coverage   91.23%   91.23%           
=======================================
  Files          20       20           
  Lines       11831    11831           
  Branches     2296     2296           
=======================================
  Hits        10794    10794           
  Misses        568      568           
  Partials      469      469           
Flag Coverage Δ
C 91.23% <ø> (ø)
python 98.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@benjeffery benjeffery force-pushed the pyproject branch 2 times, most recently from eccbdd7 to f20b626 Compare September 5, 2025 11:01
@benjeffery benjeffery marked this pull request as ready for review September 5, 2025 11:13
@benjeffery
Copy link
Copy Markdown
Member Author

@jeromekelleher Ready for review

@benjeffery benjeffery enabled auto-merge September 5, 2025 12:18
@benjeffery benjeffery added this pull request to the merge queue Sep 5, 2025
Merged via the queue into tskit-dev:main with commit 589740a Sep 5, 2025
13 checks passed
@benjeffery benjeffery deleted the pyproject branch September 5, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants