Skip network flag

Author: benjeffery

docs/development.md

@@ -529,6 +529,13 @@ under 20 seconds on an modern workstation:
 $ python3 -m pytest --skip-slow
 ```
 
+If you have an agent running the tests in a sandboxed environment, you may need to
+skip tests thsat require network access or FIFOs:
+
+```bash
+$ python3 -m pytest --skip-network
+```
+
 If you have a lot of failing tests it can be useful to have a shorter summary
 of the failing lines:
 

python/tests/conftest.py

@@ -52,6 +52,12 @@ def pytest_addoption(parser):
     parser.addoption(
         "--skip-slow", action="store_true", default=False, help="Skip slow tests"
     )
+    parser.addoption(
+        "--skip-network",
+        action="store_true",
+        default=False,
+        help="Skip network/FIFO tests",
+    )
     parser.addoption(
         "--overwrite-expected-visualizations",
         action="store_true",
@@ -71,6 +77,7 @@ def pytest_configure(config):
     Add docs on the "slow" marker
     """
     config.addinivalue_line("markers", "slow: mark test as slow to run")
+    config.addinivalue_line("markers", "network: mark test as using network/FIFO")
 
 
 def pytest_collection_modifyitems(config, items):
@@ -79,6 +86,11 @@ def pytest_collection_modifyitems(config, items):
         for item in items:
             if "slow" in item.keywords:
                 item.add_marker(skip_slow)
+    if config.getoption("--skip-network"):
+        skip_network = pytest.mark.skip(reason="--skip-network specified")
+        for item in items:
+            if "network" in item.keywords:
+                item.add_marker(skip_network)
 
 
 @fixture

python/tests/test_fileobj.py

@@ -242,6 +242,7 @@ def stream(fifo, ts_list):
         assert ts.tables == ts_out.tables
 
 
+@pytest.mark.network
 @pytest.mark.skipif(IS_WINDOWS, reason="No FIFOs on Windows")
 @pytest.mark.skipif(IS_OSX, reason="FIFO flakey on OS X, issue #1170")
 class TestFIFO:
@@ -286,6 +287,7 @@ def server_process(q):
     server.serve_forever()
 
 
+@pytest.mark.network
 @pytest.mark.skipif(IS_WINDOWS or IS_OSX, reason="Errors on systems without proper fds")
 class TestSocket:
     @fixture
@@ -339,6 +341,7 @@ def write_and_read_from_fifo(fifo_path, file_path, expected_exception, error_tex
         read_process.join(timeout=3)
 
 
+@pytest.mark.network
 @pytest.mark.skipif(IS_WINDOWS, reason="No FIFOs on Windows")
 class TestBadStream:
     def test_bad_stream(self, tmp_path):