Address comments

Author: benjeffery

python/CHANGELOG.rst

@@ -4,7 +4,7 @@
 
 **Features**
 
-- Add ``TreeSequence.individual_nodes`` method to return the nodes
+- Add ``TreeSequence.individual_nodes`` attribute to return the nodes
   associated with each individual as a numpy array.
   (:user:`benjeffery`, :pr:`3153`)
 

python/_tskitmodule.c

@@ -8731,11 +8731,12 @@ TreeSequence_get_individuals_nodes(TreeSequence *self)
     PyArrayObject *ret_array = NULL;
     npy_intp dims[2];
     tsk_size_t num_individuals;
+    tsk_size_t ploidy;
     tsk_size_t max_ploidy = 0;
     tsk_id_t *node_mem;
     tsk_size_t j;
-    tsk_id_t **individual_nodes;
-    tsk_size_t *individual_nodes_length;
+    const tsk_id_t **individual_nodes;
+    const tsk_size_t *individual_nodes_length;
 
     if (TreeSequence_check_state(self) != 0) {
         goto out;
@@ -8747,7 +8748,7 @@ TreeSequence_get_individuals_nodes(TreeSequence *self)
     individual_nodes_length = self->tree_sequence->individual_nodes_length;
 
     for (tsk_id_t i = 0; i < (tsk_id_t)num_individuals; i++) {
-        tsk_size_t ploidy = individual_nodes_length[i];
+        ploidy = individual_nodes_length[i];
         if (ploidy > max_ploidy) {
             max_ploidy = ploidy;
         }
@@ -8765,7 +8766,7 @@ TreeSequence_get_individuals_nodes(TreeSequence *self)
     memset(node_mem, 0xFF, PyArray_NBYTES(ret_array));
 
     for (tsk_id_t i = 0; i < (tsk_id_t)num_individuals; i++) {
-        tsk_size_t ploidy = individual_nodes_length[i];
+        ploidy = individual_nodes_length[i];
         for (j = 0; j < ploidy; j++) {
             node_mem[i * max_ploidy + j] = individual_nodes[i][j];
         }