Skip to content

Commit 9bba0bf

Browse files
committed
use general stat function in C test
It's impossible to test that error mode with the C summary functions. Also, rename `tsk_treeseq_two_locus_count_general_stat` to `tsk_treeseq_two_locus_general_count_stat`. It makes more sense this way.
1 parent 44c5922 commit 9bba0bf

4 files changed

Lines changed: 8 additions & 7 deletions

File tree

c/tests/test_stats.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3680,8 +3680,9 @@ test_two_locus_stat_input_errors(void)
36803680
row_sites, NULL, num_sites, col_sites, NULL, 0, result);
36813681
CU_ASSERT_EQUAL_FATAL(ret, 0);
36823682

3683-
ret = tsk_treeseq_r2(&ts, num_sample_sets, 0, sample_sets, num_sites, row_sites,
3684-
NULL, num_sites, col_sites, NULL, 0, result);
3683+
ret = tsk_treeseq_two_locus_general_count_stat(&ts, num_sample_sets,
3684+
sample_set_sizes, sample_sets, 0, NULL, NULL, NULL, num_sites, row_sites, NULL,
3685+
num_sites, col_sites, NULL, 0, result);
36853686
CU_ASSERT_EQUAL_FATAL(ret, TSK_ERR_BAD_RESULT_DIMS);
36863687

36873688
ret = tsk_treeseq_r2(&ts, 1, sample_set_sizes, sample_sets, num_sites, row_sites,

c/tskit/trees.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3392,7 +3392,7 @@ check_sample_set_dups(tsk_size_t num_sample_sets, const tsk_size_t *sample_set_s
33923392

33933393
/* Called directly by C python interface `two_locus_count_stat` */
33943394
int
3395-
tsk_treeseq_two_locus_count_general_stat(const tsk_treeseq_t *self,
3395+
tsk_treeseq_two_locus_general_count_stat(const tsk_treeseq_t *self,
33963396
tsk_size_t num_sample_sets, const tsk_size_t *sample_set_sizes,
33973397
const tsk_id_t *sample_sets, tsk_size_t result_dim, general_stat_func_t *f,
33983398
void *f_params, norm_func_t *norm_f, tsk_size_t out_rows, const tsk_id_t *row_sites,
@@ -3466,7 +3466,7 @@ tsk_treeseq_two_locus_count_general_stat(const tsk_treeseq_t *self,
34663466
return ret;
34673467
}
34683468

3469-
/* Wrapper of `tsk_treeseq_two_locus_count_general_stat` for C summary Functions */
3469+
/* Wrapper of `tsk_treeseq_two_locus_general_count_stat` for C summary Functions */
34703470
static int
34713471
tsk_treeseq_two_locus_count_stat(const tsk_treeseq_t *self, tsk_size_t num_sample_sets,
34723472
const tsk_size_t *sample_set_sizes, const tsk_id_t *sample_sets,
@@ -3479,7 +3479,7 @@ tsk_treeseq_two_locus_count_stat(const tsk_treeseq_t *self, tsk_size_t num_sampl
34793479
.num_sample_sets = num_sample_sets,
34803480
.sample_set_sizes = sample_set_sizes,
34813481
.set_indexes = set_indexes };
3482-
return tsk_treeseq_two_locus_count_general_stat(self, num_sample_sets,
3482+
return tsk_treeseq_two_locus_general_count_stat(self, num_sample_sets,
34833483
sample_set_sizes, sample_sets, result_dim, f, &f_params, norm_f, out_rows,
34843484
row_sites, row_positions, out_cols, col_sites, col_positions, options, result);
34853485
}

c/tskit/trees.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1112,7 +1112,7 @@ typedef int general_sample_stat_method(const tsk_treeseq_t *self,
11121112
const tsk_id_t *sample_sets, tsk_size_t num_indexes, const tsk_id_t *indexes,
11131113
tsk_size_t num_windows, const double *windows, tsk_flags_t options, double *result);
11141114

1115-
int tsk_treeseq_two_locus_count_general_stat(const tsk_treeseq_t *self,
1115+
int tsk_treeseq_two_locus_general_count_stat(const tsk_treeseq_t *self,
11161116
tsk_size_t num_sample_sets, const tsk_size_t *sample_set_sizes,
11171117
const tsk_id_t *sample_sets, tsk_size_t result_dim, general_stat_func_t *f,
11181118
void *f_params, norm_func_t *norm_f, tsk_size_t out_rows, const tsk_id_t *row_sites,

python/_tskitmodule.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8196,7 +8196,7 @@ TreeSequence_two_locus_count_stat(TreeSequence *self, PyObject *args, PyObject *
81968196
.summary_func = summary_func,
81978197
.norm_func = norm_func,
81988198
};
8199-
err = tsk_treeseq_two_locus_count_general_stat(self->tree_sequence, num_sample_sets,
8199+
err = tsk_treeseq_two_locus_general_count_stat(self->tree_sequence, num_sample_sets,
82008200
PyArray_DATA(sample_set_sizes_array), PyArray_DATA(sample_sets_array),
82018201
output_dim, general_two_locus_count_stat_func, params,
82028202
general_two_locus_norm_func, result_dim[0], row_sites_parsed,

0 commit comments

Comments
 (0)